From fd45a48da446dd8d8ae480df53f12ccc4365b451 Mon Sep 17 00:00:00 2001 From: arbirali Date: Thu, 15 May 2025 12:51:14 +0500 Subject: [PATCH 1/3] feat: increase focus visible thickness --- .../indigo/lms/static/sass/partials/lms/theme/_extras.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss index ef2f0d9e2..8d932cf44 100644 --- a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss +++ b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss @@ -33,6 +33,11 @@ input:-webkit-autofill:active{ border: none; } +:focus, +:focus-visible { + outline-width: 2px; +} + %btn-pl-default-base { border-radius: 0; } From 9c91debc3bcc0ae13028f7552bcb930680235516 Mon Sep 17 00:00:00 2001 From: arbirali Date: Mon, 19 May 2025 16:19:05 +0500 Subject: [PATCH 2/3] feat: Missing clear focus indicators on multiple page elements. --- .../indigo/lms/static/sass/home/_home.scss | 19 ++++--- .../sass/partials/lms/theme/_extras.scss | 51 ++++++++++++++----- .../templates/indigo/lms/templates/index.html | 10 ++-- 3 files changed, 53 insertions(+), 27 deletions(-) diff --git a/tutorindigo/templates/indigo/lms/static/sass/home/_home.scss b/tutorindigo/templates/indigo/lms/static/sass/home/_home.scss index 2543bc6cb..7cd073b07 100644 --- a/tutorindigo/templates/indigo/lms/static/sass/home/_home.scss +++ b/tutorindigo/templates/indigo/lms/static/sass/home/_home.scss @@ -32,6 +32,7 @@ section.home { #main .home.style-logout { header { background: none; + overflow: visible; .outer-wrapper { .title { width: 100%; @@ -73,13 +74,9 @@ section.home { .course-search { padding: 0; .search-field-wrapper { - &:after { - clear: both; - content: ""; - display: block; - } - .button-holder { - float: right; + display: flex; + + .button-holder { button { position: static; margin: 0 0 0 16px; @@ -105,7 +102,7 @@ section.home { } } .input-holder { - overflow: hidden; + flex-grow: 1; border-radius: 6px; background: $primary-light; padding: 0 0 0 33px; @@ -127,6 +124,12 @@ section.home { font-size: 14px; line-height: 20px; padding: 9px 10px; + + &:focus, + &:focus-visible { + outline: revert; + outline-width: 2px; + } } } } diff --git a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss index 8d932cf44..7be953fc2 100644 --- a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss +++ b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss @@ -26,6 +26,18 @@ input:-webkit-autofill:active{ transition: background-color 5000s ease-in-out 0s; box-shadow: none; } + +.register-btn, +.sign-in-btn, +.search-button, +.learn-more { + &:focus, + &:focus-visible { + outline-offset: 3px; + } +} + + .page-content-container { max-width: 1600px; margin: 0 auto; @@ -419,33 +431,30 @@ body.view-instructordash { background: $primary; color: white; margin: 0 0 10px; + outline-offset: 3px; } .instructor-nav { overflow: hidden; width: 100%; white-space: nowrap; overflow-x: auto; - border: 1px solid #E5E7EB; - border-radius: 6px; - padding: 0 !important; - letter-spacing: -.32em; + display: flex; + border: 0; + padding: 3px; + li { - letter-spacing: normal; - &:first-child { - button { - border: none; - } - } + margin-right: -1px; + button { - border: none !important; - border-radius: 0 !important; - border-left: 1px solid #E5E7EB !important; + border-radius: 0; + border: 1px solid #E5E7EB !important; font-size: 14px; line-height: 20px; font-weight: 500; padding: 9px 17px; color: #374151; text-decoration: none !important; + outline-offset: 3px; &.active-section { background: $primary !important; color: white !important; @@ -454,7 +463,21 @@ body.view-instructordash { color: $dark; } &:focus { - box-shadow: inset 0 0 0 2px $primary !important; + position: relative; + z-index: 1; + } + } + + &:first-of-type { + button { + border: none; + border-radius: 6px 0 0 6px; + } + } + + &:last-of-type { + button { + border-radius: 0 6px 6px 0; } } } diff --git a/tutorindigo/templates/indigo/lms/templates/index.html b/tutorindigo/templates/indigo/lms/templates/index.html index 2e47b7e13..bc1a3c533 100644 --- a/tutorindigo/templates/indigo/lms/templates/index.html +++ b/tutorindigo/templates/indigo/lms/templates/index.html @@ -25,17 +25,17 @@
-
- -
+
+ +
From 6eab174665af9a4dc90acfcb71b7de853f20b056 Mon Sep 17 00:00:00 2001 From: arbirali Date: Tue, 20 May 2025 19:46:17 +0500 Subject: [PATCH 3/3] fix: instructor navbar fixes for the dark mode --- .../indigo/lms/static/sass/partials/lms/theme/_extras.scss | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss index 7be953fc2..a8b640135 100644 --- a/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss +++ b/tutorindigo/templates/indigo/lms/static/sass/partials/lms/theme/_extras.scss @@ -440,7 +440,7 @@ body.view-instructordash { overflow-x: auto; display: flex; border: 0; - padding: 3px; + padding: 5px; li { margin-right: -1px; @@ -905,7 +905,7 @@ body.indigo-dark-theme { box-shadow: none !important; } .instructor-nav { - border: 1px solid #E5E7EB; + li { &:first-child { button { @@ -913,9 +913,6 @@ body.indigo-dark-theme { } } button { - border: none !important; - border-radius: 0 !important; - border-left: 1px solid #E5E7EB !important; color: $text-color-primary; &.active-section { background: $primary-d !important;