Bump pinia from 2.2.4 to 2.2.8

[dependabot]

Bumps pinia from 2.2.4 to 2.2.8.

Release notes

Sourced from pinia's releases.

pinia@2.2.6

Please refer to CHANGELOG.md for details.

pinia@2.2.5

Please refer to CHANGELOG.md for details.

Commits

• 4715104 release: pinia@2.2.8
• f939868 test: unused import
• 1064c3e chore: ignore file
• 7097fc4 test: organize and use vitest
• 3223983 docs: Nuxt 2 --> 3 (#2766)
• 67d3109 fix: avoid immediate computing with storeToRefs
• ea14e53 fix(types): unwrap refs in mapWritableState for setup stores (#2805)
• d1858e8 feat: deprecate old defineStore
• 64fbd46 docs: note about nuxt module needing pinia
• 3269742 release: @​pinia/nuxt@​0.8.0
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[ezio-melotti]

This is still failing even with the fix included in v2.2.8. See also:

• Bump pinia from 2.2.4 to 2.2.6 #844
• Bump pinia from 2.2.4 to 2.2.7 #877

My understanding is that once the app is started, the setup() in Welcome.vue is executed:

simoc-web/src/components/entry/Welcome.vue

Lines 87 to 93 in 54ce23a

	setup() {
	const dashboard = useDashboardStore()
	const wizard = useWizardStore()
	const {kioskMode} = storeToRefs(dashboard)
	const {activeConfigType} = storeToRefs(wizard)
	return {kioskMode, activeConfigType}
	},

Line 91 executes storeToRefs(wizard) which imports the wizard store, and since the change in behavior introduced in v2.2.5, the computed properties (including getters) are eagerly evaluated:

simoc-web/src/store/modules/WizardStore.js

Lines 340 to 348 in 54ce23a

	getters: {
	// This method converts the total mission time to hours regardless of the units selected.
	// As one step = one hour.
	getActiveForm: state => state.formOrder[state.activeFormIndex],
	getTotalMissionHours(state) {
	let totalHours = 0
	const durationLength = state.configuration.duration.amount
	const durationUnits = state.configuration.duration.units

Since the configuration is only available after going through the configuration wizard, these getters are now failing. I'm also assuming other getters are now being evaluated (successfully), which even though it doesn't result in failures, it might have unintended side-effects.

[dependabot]

Superseded by #888.

[ezio-melotti]

Pinia v2.3.0 seems to work (see #888).