From 98d6161a8346946cb75b73a6ed74c76639035454 Mon Sep 17 00:00:00 2001 From: Ciaran Schutte Date: Mon, 21 Oct 2024 13:44:49 -0400 Subject: [PATCH 1/2] improve comment --- modules/server/src/network/resolvers/aggregations.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/server/src/network/resolvers/aggregations.ts b/modules/server/src/network/resolvers/aggregations.ts index d6ccdc755..0bb9d6dd8 100644 --- a/modules/server/src/network/resolvers/aggregations.ts +++ b/modules/server/src/network/resolvers/aggregations.ts @@ -103,11 +103,13 @@ const convertFieldsToString = (requestedFields: RequestedFieldsMap) => { }; /** - * Query string creation + * Creates individual GQL query string for a node. + * Includes aggregation GQL arguments (actual data is provided alongside query, not here) + * Requested fields are converted to GQL style strings * * @param documentName * @param requestedFields - * @returns + * @returns constructed query string */ export const createNodeQueryString = ( documentName: string, From 0c31f7e3b7aaf1f8a514df3b8154174748af49f2 Mon Sep 17 00:00:00 2001 From: Ciaran Schutte Date: Mon, 21 Oct 2024 13:55:21 -0400 Subject: [PATCH 2/2] improve comment --- modules/server/src/network/resolvers/index.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/server/src/network/resolvers/index.ts b/modules/server/src/network/resolvers/index.ts index f41f00165..c7148530b 100644 --- a/modules/server/src/network/resolvers/index.ts +++ b/modules/server/src/network/resolvers/index.ts @@ -12,6 +12,9 @@ export type NetworkSearchRoot = { aggregations: Record; }; +/* + * Type should match the "Network" GQL type definition arg types + */ export type NetworkAggregationArgs = { filters?: object; aggregations_filter_themselves?: boolean; @@ -33,7 +36,7 @@ export const createResolvers = (configs: NodeConfig[]) => { Query: { network: async ( parent: NetworkSearchRoot, - // type should match gql typedefs + // as mentioned above, type should match gql typedefs args: NetworkAggregationArgs, context: unknown, info: GraphQLResolveInfo,