This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
[Analyzer] Return and Yield in one Method #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lexty
force-pushed
the
185-analyzer-return-and-yield-in-one-method
branch
from
149408f to
930c813
Compare
|
Well I'll wait. I like this project for quick response. Thanks! |
|
@Lexty A added some methods and tests related your PR in master |
8 tasks
|
Thanks @Lexty for PR, I am going to close it to create another PR to rebase and fix it And happy Halloween day :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Type: new feature
Link to issue: #185
This pull request affects the following components (please check boxes):
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Adds a new Analyzer that raises a notice for using return and yield statements in a one method.
Also there are small changes in
PHPSA\Analyzer\Helper\ResolveExpressionTrait(addedfindStatementmethod and changedfindReturnStatementmethod).This is my last PR for the
hacktoberfestlabel. Next will try something else.Thanks.