✨ Refactor & speedup insights search #3631
Merged
+572
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippetAutomatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2024-11-28 08:48:46 UTC |
Marigold
force-pushed
the
insight-search-cache
branch
from
edbc0bd to
bbe77bb
Compare
Marigold
force-pushed
the
insight-search-cache
branch
from
8e5a726 to
3812111
Compare
Marigold
force-pushed
the
insight-search-cache
branch
from
3812111 to
8889d92
Compare
Marigold
changed the title
lucasrodes
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and speed up insights search. Its functionality isn't changing. Link to insights search on staging.
Refactoring
Insightobject instead of dictsurl_persistPerformance
Instead of calculating embeddings on every launch, save them to disk and add missing ones on every load. This makes initial loading almost instant and also speeds up search.