From 0b07d32c89a1e6af61a5b6fc435d60984d2f5d73 Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 11 Nov 2016 18:36:41 +0100 Subject: [PATCH] Remove config change hook that deletes link shares Seems broken. But also if link shares are not allowed, the link shares will continue to exist but will be denied. A future cleanup could be done through a background job. --- apps/files_sharing/lib/Helper.php | 1 - apps/files_sharing/lib/Maintainer.php | 46 --------------------------- 2 files changed, 47 deletions(-) delete mode 100644 apps/files_sharing/lib/Maintainer.php diff --git a/apps/files_sharing/lib/Helper.php b/apps/files_sharing/lib/Helper.php index f8b6c478f25e..3e352d7e316d 100644 --- a/apps/files_sharing/lib/Helper.php +++ b/apps/files_sharing/lib/Helper.php @@ -39,7 +39,6 @@ class Helper { public static function registerHooks() { \OCP\Util::connectHook('OC_Filesystem', 'post_rename', '\OCA\Files_Sharing\Updater', 'renameHook'); \OCP\Util::connectHook('OC_Filesystem', 'post_delete', '\OCA\Files_Sharing\Hooks', 'unshareChildren'); - \OCP\Util::connectHook('OC_Appconfig', 'post_set_value', '\OCA\Files_Sharing\Maintainer', 'configChangeHook'); \OCP\Util::connectHook('OC_User', 'post_deleteUser', '\OCA\Files_Sharing\Hooks', 'deleteUser'); } diff --git a/apps/files_sharing/lib/Maintainer.php b/apps/files_sharing/lib/Maintainer.php deleted file mode 100644 index b4557cfb8db2..000000000000 --- a/apps/files_sharing/lib/Maintainer.php +++ /dev/null @@ -1,46 +0,0 @@ - - * @author Robin McCorkell - * @author Roeland Jago Douma - * - * @copyright Copyright (c) 2016, ownCloud GmbH. - * @license AGPL-3.0 - * - * This code is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License, version 3, - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License, version 3, - * along with this program. If not, see - * - */ - -namespace OCA\Files_Sharing; - -/** - * Maintains stuff around the sharing functionality - * - * for example: on disable of "allow links" it removes all link shares - */ - -class Maintainer { - - /** - * Keeps track of the "allow links" config setting - * and removes all link shares if the config option is set to "no" - * - * @param array $params array with app, key, value as named values - */ - static public function configChangeHook($params) { - if($params['app'] === 'core' && $params['key'] === 'shareapi_allow_links' && $params['value'] === 'no') { - \OCP\Share::removeAllLinkShares(); - } - } - -}