From c3bf29ad24ab4479671844dff090ca8c6998034c Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 8 Mar 2019 17:19:01 +0100 Subject: [PATCH] Remove incompatible script for generating DB changeset Since the move to DB migrations, this script cannot work any more, especially considering that there can be non-DB migrations in the mix. --- core/Command/Db/GenerateChangeScript.php | 56 ------------------------ core/register_command.php | 1 - 2 files changed, 57 deletions(-) delete mode 100644 core/Command/Db/GenerateChangeScript.php diff --git a/core/Command/Db/GenerateChangeScript.php b/core/Command/Db/GenerateChangeScript.php deleted file mode 100644 index 7461b42970ff..000000000000 --- a/core/Command/Db/GenerateChangeScript.php +++ /dev/null @@ -1,56 +0,0 @@ - - * @author Thomas Müller - * - * @copyright Copyright (c) 2018, ownCloud GmbH - * @license AGPL-3.0 - * - * This code is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License, version 3, - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License, version 3, - * along with this program. If not, see - * - */ - -namespace OC\Core\Command\Db; - -use Symfony\Component\Console\Command\Command; -use Symfony\Component\Console\Input\InputArgument; -use Symfony\Component\Console\Input\InputInterface; -use Symfony\Component\Console\Output\OutputInterface; - -class GenerateChangeScript extends Command { - protected function configure() { - $this - ->setName('db:generate-change-script') - ->setDescription('Generates the change script from the current connected db to db_structure.xml.') - ->addArgument( - 'schema-xml', - InputArgument::OPTIONAL, - 'The XML schema to be used as the target schema.', - \OC::$SERVERROOT . '/db_structure.xml' - ) - ; - } - - protected function execute(InputInterface $input, OutputInterface $output) { - $file = $input->getArgument('schema-xml'); - - $schemaManager = new \OC\DB\MDB2SchemaManager(\OC::$server->getDatabaseConnection()); - - try { - $result = $schemaManager->updateDbFromStructure($file, true); - $output->writeln($result); - } catch (\Exception $e) { - $output->writeln('Failed to update database structure ('.$e.')'); - } - } -} diff --git a/core/register_command.php b/core/register_command.php index b4a2872c8581..0af103369684 100644 --- a/core/register_command.php +++ b/core/register_command.php @@ -83,7 +83,6 @@ $application->add(new OC\Core\Command\Config\System\GetConfig(\OC::$server->getSystemConfig())); $application->add(new OC\Core\Command\Config\System\SetConfig(\OC::$server->getSystemConfig())); - $application->add(new OC\Core\Command\Db\GenerateChangeScript()); $application->add(new OC\Core\Command\Db\ConvertType(\OC::$server->getConfig(), new \OC\DB\ConnectionFactory(\OC::$server->getSystemConfig()))); $application->add(new OC\Core\Command\Db\ConvertMysqlToMB4(\OC::$server->getConfig(), \OC::$server->getDatabaseConnection(), \OC::$server->getURLGenerator())); $application->add(new OC\Core\Command\Db\Migrations\StatusCommand(\OC::$server->getDatabaseConnection()));