Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #202

Open
HanaGemela opened this issue Mar 2, 2020 · 9 comments
Open

Fix build warnings #202

HanaGemela opened this issue Mar 2, 2020 · 9 comments
Assignees

Comments

@HanaGemela
Copy link
Contributor

When building files mediaviewer I'm getting the below warnings

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistenc

warning sha.js@2.4.11: Invalid bin entry for "sha.js" (in "sha.js").

warning Your current version of Yarn is out of date. The latest version is "1.22.0", while you're on "1.21.1".
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
    This can impact web performance.
    Assets:
      files_mediaviewer.js (311 KiB)

    WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
    Entrypoints:
      main (311 KiB)
          files_mediaviewer.js


    WARNING in webpack performance recommendations:
    You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
    For more info visit https://webpack.js.org/guides/code-splitting/
@HanaGemela HanaGemela changed the title Fix build warning Fix build warnings Mar 2, 2020
DeepDiver1975 added a commit that referenced this issue Mar 2, 2020
@DeepDiver1975
Copy link
Member

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistenc

#203

@DeepDiver1975
Copy link
Member

warning Your current version of Yarn is out of date. The latest version is "1.22.0", wh

An issue on the system you did get these errors. Nothing we can/have to fix

@DeepDiver1975
Copy link
Member

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
    This can impact web performance.
    Assets:
      files_mediaviewer.js (311 KiB)

can be ignored for now

@DeepDiver1975
Copy link
Member

warning sha.js@2.4.11: Invalid bin entry for "sha.js" (in "sha.js").

upstream issue: browserify/sha.js#64 - nothing to do for us

@micbar
Copy link
Contributor

micbar commented Mar 2, 2020

@HanaGemela Updated the docker container.
This is a private container image, not on docker hub.

So please cd into releasescripts
git checkout master
git pull
cd docker
docker build -t oc_release:latest .

this should update your local image.

@HanaGemela
Copy link
Contributor Author

Apart from point 4, all fixed

@DeepDiver1975
Copy link
Member

Apart from point 4, all fixed

no really an issue for us and our deployments -> I vote for close

@LukasHirt
Copy link
Collaborator

no really an issue for us and our deployments

This leads to higher consumption of users data package in case they are accessing the app with them and a bit slower performance. I think opening a separate issue for it would be reasonable.

@DeepDiver1975
Copy link
Member

This leads to higher consumption of users data package in case they are accessing the app with them and a bit slower performance.

we are talking about an oc10 app here - oc10 already loads a hell of js and css. Optimizations on this end will have zero effect. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants