From c3126b9c866f25bd3ec72d6457e47acad326c83e Mon Sep 17 00:00:00 2001 From: Viktor Scharf Date: Mon, 12 Feb 2024 15:09:44 +0100 Subject: [PATCH 1/2] fix test: secret file drop --- .../acceptance/expected-failures-API-on-OCIS-storage.md | 4 ---- .../uploadToPublicLinkShare.feature | 9 +++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/expected-failures-API-on-OCIS-storage.md b/tests/acceptance/expected-failures-API-on-OCIS-storage.md index b6666549810..9f10eec8873 100644 --- a/tests/acceptance/expected-failures-API-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-API-on-OCIS-storage.md @@ -115,10 +115,6 @@ cannot share a folder with create permission - [coreApiSharePublicLink2/copyFromPublicLink.feature:193](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink2/copyFromPublicLink.feature#L193) - [coreApiSharePublicLink2/copyFromPublicLink.feature:194](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink2/copyFromPublicLink.feature#L194) -#### [Upload-only shares must not overwrite but create a separate file](https://github.com/owncloud/ocis/issues/1267) - -- [coreApiSharePublicLink2/uploadToPublicLinkShare.feature:13](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature#L13) - #### [d:quota-available-bytes in dprop of PROPFIND give wrong response value](https://github.com/owncloud/ocis/issues/8197) - [coreApiWebdavProperties/getQuota.feature:55](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavProperties/getQuota.feature#L55) diff --git a/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature index 518ac93df48..1fc8f100c30 100644 --- a/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature @@ -17,13 +17,14 @@ Feature: upload to a public link share | permissions | create | | password | %public% | When the public uploads file "test.txt" with password "%public%" and content "test" using the new public WebDAV API + Then the HTTP status code should be "201" + And the content of file "/FOLDER/test.txt" for user "Alice" should be "test" When the public uploads file "test.txt" with password "%public%" and content "test2" using the new public WebDAV API - Then the HTTP status code of responses on all endpoints should be "201" + Then the HTTP status code should be "201" + And the content of file "/FOLDER/test (2).txt" for user "Alice" should be "test2" And the following headers should match these regular expressions | ETag | /^"[a-f0-9:\.]{1,32}"$/ | - And the content of file "/FOLDER/test.txt" for user "Alice" should be "test" - And the content of file "/FOLDER/test (2).txt" for user "Alice" should be "test2" - + Scenario Outline: uploading file to a public upload-only share using public API that was deleted does not work Given using DAV path From 792b2120a04f3fe6f7eecdc6a86b1bc76db0069c Mon Sep 17 00:00:00 2001 From: Viktor Scharf Date: Mon, 12 Feb 2024 20:59:22 +0100 Subject: [PATCH 2/2] Update uploadToPublicLinkShare.feature --- .../uploadToPublicLinkShare.feature | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature index 1fc8f100c30..0e4a398e57c 100644 --- a/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink2/uploadToPublicLinkShare.feature @@ -8,22 +8,6 @@ Feature: upload to a public link share Background: Given user "Alice" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" - - @smokeTest @issue-1267 - Scenario: uploading same file to a public upload-only share multiple times via new API - # The new API does the auto rename in upload-only folders - Given user "Alice" has created a public link share with settings - | path | FOLDER | - | permissions | create | - | password | %public% | - When the public uploads file "test.txt" with password "%public%" and content "test" using the new public WebDAV API - Then the HTTP status code should be "201" - And the content of file "/FOLDER/test.txt" for user "Alice" should be "test" - When the public uploads file "test.txt" with password "%public%" and content "test2" using the new public WebDAV API - Then the HTTP status code should be "201" - And the content of file "/FOLDER/test (2).txt" for user "Alice" should be "test2" - And the following headers should match these regular expressions - | ETag | /^"[a-f0-9:\.]{1,32}"$/ | Scenario Outline: uploading file to a public upload-only share using public API that was deleted does not work