From 236ca33117a62364b12f221d903c9f610a6c5a23 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Fri, 20 Jan 2023 17:15:17 +0100
Subject: [PATCH] Disable more compat features

---
 .../src/components/OcButton/OcButton.vue      |  4 +--
 .../src/components/OcImage/OcImage.vue        |  2 +-
 .../src/components/OcSelect/OcSelect.vue      | 24 +++++++++++++
 .../__snapshots__/MembersPanel.spec.ts.snap   |  4 +--
 .../__snapshots__/DetailsAndEdit.spec.ts.snap |  2 +-
 packages/web-runtime/src/compatConfig.ts      | 36 +++++++++----------
 6 files changed, 48 insertions(+), 24 deletions(-)

diff --git a/packages/design-system/src/components/OcButton/OcButton.vue b/packages/design-system/src/components/OcButton/OcButton.vue
index 4d2c9e37e3a..2860cc88233 100644
--- a/packages/design-system/src/components/OcButton/OcButton.vue
+++ b/packages/design-system/src/components/OcButton/OcButton.vue
@@ -4,7 +4,6 @@
     v-bind="additionalAttributes"
     :aria-label="ariaLabel"
     :class="$_ocButton_buttonClass"
-    :disabled="disabled"
     v-on="handlers"
   >
     <!-- @slot Content of the button -->
@@ -159,7 +158,8 @@ export default defineComponent({
         ...(this.href && { href: this.href }),
         ...(this.target && { target: this.target }),
         ...(this.to && { to: this.to }),
-        ...(this.type === 'button' && { type: this.submit })
+        ...(this.type === 'button' && { type: this.submit }),
+        ...(this.type === 'button' && { disabled: this.disabled })
       }
     },
 
diff --git a/packages/design-system/src/components/OcImage/OcImage.vue b/packages/design-system/src/components/OcImage/OcImage.vue
index 7b895ccf3c4..806abb21d78 100644
--- a/packages/design-system/src/components/OcImage/OcImage.vue
+++ b/packages/design-system/src/components/OcImage/OcImage.vue
@@ -1,5 +1,5 @@
 <template>
-  <img :src="src" :alt="alt" :aria-hidden="!alt" :title="title" :loading="loadingType" />
+  <img :src="src" :alt="alt" :aria-hidden="`${!alt}`" :title="title" :loading="loadingType" />
 </template>
 <script lang="ts">
 import { defineComponent } from 'vue'
diff --git a/packages/design-system/src/components/OcSelect/OcSelect.vue b/packages/design-system/src/components/OcSelect/OcSelect.vue
index b767dda86c0..d0a73878a79 100644
--- a/packages/design-system/src/components/OcSelect/OcSelect.vue
+++ b/packages/design-system/src/components/OcSelect/OcSelect.vue
@@ -99,6 +99,30 @@ export default defineComponent({
     optionLabel: {
       type: String,
       default: null
+    },
+    /**
+     * Determines if the select field is searchable
+     */
+    searchable: {
+      type: Boolean,
+      required: false,
+      default: false
+    },
+    /**
+     * Determines if the select field is clearable
+     */
+    clearable: {
+      type: Boolean,
+      required: false,
+      default: false
+    },
+    /**
+     * Determines if the select field loading
+     */
+    loading: {
+      type: Boolean,
+      required: false,
+      default: false
     }
   },
   emits: ['search:input', 'update:modelValue'],
diff --git a/packages/web-app-admin-settings/tests/unit/components/Spaces/SideBar/__snapshots__/MembersPanel.spec.ts.snap b/packages/web-app-admin-settings/tests/unit/components/Spaces/SideBar/__snapshots__/MembersPanel.spec.ts.snap
index 1bd6f090f2e..28f5b605ed4 100644
--- a/packages/web-app-admin-settings/tests/unit/components/Spaces/SideBar/__snapshots__/MembersPanel.spec.ts.snap
+++ b/packages/web-app-admin-settings/tests/unit/components/Spaces/SideBar/__snapshots__/MembersPanel.spec.ts.snap
@@ -2,7 +2,7 @@
 
 exports[`MembersPanel should display an empty result if no matching members found 1`] = `
 <div class="oc-ml-s">
-  <oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-3" label="Filter members" type="text" value="no-match"></oc-text-input-stub>
+  <oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-3" label="Filter members" modelvalue="no-match" type="text"></oc-text-input-stub>
   <div>
     <div>
       <h3 class="oc-text-bold oc-text-medium">No members found</h3>
@@ -16,7 +16,7 @@ exports[`MembersPanel should display an empty result if no matching members foun
 
 exports[`MembersPanel should render all members accordingly to their role assignments 1`] = `
 <div class="oc-ml-s">
-  <oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-1" label="Filter members" type="text" value=""></oc-text-input-stub>
+  <oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-1" label="Filter members" modelvalue="" type="text"></oc-text-input-stub>
   <div>
     <!--v-if-->
     <div class="oc-mb-m">
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/Links/__snapshots__/DetailsAndEdit.spec.ts.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/Links/__snapshots__/DetailsAndEdit.spec.ts.snap
index 63a2a3a2991..21f432ebec5 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/Links/__snapshots__/DetailsAndEdit.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/Links/__snapshots__/DetailsAndEdit.spec.ts.snap
@@ -71,7 +71,7 @@ exports[`DetailsAndEdit component if user can edit renders dropdown and edit but
             </oc-button-stub>
           </li>
           <li class="oc-rounded oc-menu-item-hover">
-            <date-picker-stub class="link-expiry-picker oc-datepicker link-expiry-picker" inputdebounce="1000" locale="en" min-date="Wed Apr 01 2020 00:00:00 GMT+0000 (Coordinated Universal Time)" mode="date" modelconfig="[object Object]" popover="[object Object]" updateoninput="true">
+            <date-picker-stub class="oc-datepicker link-expiry-picker link-expiry-picker" inputdebounce="1000" locale="en" min-date="Wed Apr 01 2020 00:00:00 GMT+0000 (Coordinated Universal Time)" mode="date" modelconfig="[object Object]" popover="[object Object]" updateoninput="true">
               <!-- @slot Default slot to use as the popover anchor for datepicker -->
               <!-- args is undefined during initial render, hence we check it here -->
               <!--v-if-->
diff --git a/packages/web-runtime/src/compatConfig.ts b/packages/web-runtime/src/compatConfig.ts
index 4fea14206a9..a506a3c9f19 100644
--- a/packages/web-runtime/src/compatConfig.ts
+++ b/packages/web-runtime/src/compatConfig.ts
@@ -2,20 +2,20 @@ import { configureCompat } from 'vue'
 
 type CompatConfig = Parameters<typeof configureCompat>[0]
 export const compatConfig: CompatConfig = {
-  MODE: 2,
-  // ATTR_ENUMERATED_COERCION: false,
+  MODE: 3,
+  ATTR_ENUMERATED_COERCION: false,
   ATTR_FALSE_VALUE: 'suppress-warning',
-  // COMPONENT_ASYNC: false,
-  // COMPONENT_FUNCTIONAL: false,
-  // COMPONENT_V_MODEL: false,
-  // CONFIG_DEVTOOLS: false,
-  // CONFIG_IGNORED_ELEMENTS: false,
-  // CONFIG_KEY_CODES: false,
-  // CONFIG_OPTION_MERGE_STRATS: false,
-  // CONFIG_PRODUCTION_TIP: false,
-  // CONFIG_SILENT: false,
-  // CONFIG_WHITESPACE: false,
-  // CUSTOM_DIR: false,
+  COMPONENT_ASYNC: false,
+  COMPONENT_FUNCTIONAL: false,
+  COMPONENT_V_MODEL: false,
+  CONFIG_DEVTOOLS: false,
+  CONFIG_IGNORED_ELEMENTS: false,
+  CONFIG_KEY_CODES: false,
+  CONFIG_OPTION_MERGE_STRATS: false,
+  CONFIG_PRODUCTION_TIP: false,
+  CONFIG_SILENT: false,
+  CONFIG_WHITESPACE: 'suppress-warning',
+  CUSTOM_DIR: false,
   FILTERS: false,
   GLOBAL_DELETE: false,
   GLOBAL_EXTEND: false,
@@ -31,18 +31,18 @@ export const compatConfig: CompatConfig = {
   INSTANCE_DESTROY: false,
   INSTANCE_EVENT_EMITTER: false,
   INSTANCE_EVENT_HOOKS: false,
-  // INSTANCE_LISTENERS: false,
+  INSTANCE_LISTENERS: false,
   INSTANCE_SCOPED_SLOTS: false,
   INSTANCE_SET: false,
   OPTIONS_BEFORE_DESTROY: false,
   OPTIONS_DATA_FN: false,
   OPTIONS_DATA_MERGE: false,
   OPTIONS_DESTROYED: false,
-  // PRIVATE_APIS: false,
+  PRIVATE_APIS: false,
   PROPS_DEFAULT_THIS: false,
   RENDER_FUNCTION: false,
-  // TRANSITION_CLASSES: false,
-  // TRANSITION_GROUP_ROOT: false,
-  // V_ON_KEYCODE_MODIFIER: false,
+  TRANSITION_CLASSES: false,
+  TRANSITION_GROUP_ROOT: false,
+  V_ON_KEYCODE_MODIFIER: false,
   WATCH_ARRAY: false
 }