From cab8fc43f449bed3b77a8136374dd9c7512f36e7 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Fri, 20 Jan 2023 14:46:49 +0100
Subject: [PATCH] Fix oc-checkbox-usages

---
 .../src/components/OcCheckbox/OcCheckbox.vue  |  2 +-
 .../src/components/Groups/GroupsList.vue      |  8 +++----
 .../src/components/Spaces/SpacesList.vue      |  8 +++----
 .../components/Users/SideBar/DetailsPanel.vue |  7 ++++--
 .../components/Users/SideBar/EditPanel.vue    |  7 +++---
 .../src/components/Users/UsersList.vue        |  9 +++----
 .../src/views/Users.vue                       |  3 ++-
 .../src/views/spaces/DriveRedirect.vue        | 24 +++++++++----------
 .../src/composables/sideBar/useSideBar.ts     |  6 ++---
 packages/web-runtime/src/compatConfig.ts      | 20 ++++++++--------
 packages/web-runtime/src/store/spaces.ts      |  2 +-
 11 files changed, 50 insertions(+), 46 deletions(-)

diff --git a/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue b/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue
index 6c81708f55f..0a5e721393d 100644
--- a/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue
+++ b/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue
@@ -6,7 +6,7 @@
       type="checkbox"
       name="checkbox"
       :class="classes"
-      :modelValue="option"
+      :value="option"
       :disabled="disabled"
     />
     <label :for="id" :class="labelClasses" v-text="label" />
diff --git a/packages/web-app-admin-settings/src/components/Groups/GroupsList.vue b/packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
index 9fde0b56f0c..50d54f43fa9 100644
--- a/packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
+++ b/packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
@@ -23,20 +23,20 @@
           size="large"
           class="oc-ml-s"
           :label="$gettext('Select all groups')"
-          :value="allGroupsSelected"
+          :model-value="allGroupsSelected"
           hide-label
-          @input="$emit('toggleSelectAllGroups')"
+          @update:modelValue="$emit('toggleSelectAllGroups')"
         />
       </template>
       <template #select="rowData">
         <oc-checkbox
           class="oc-ml-s"
           size="large"
-          :value="selectedGroups"
+          :model-value="selectedGroups"
           :option="rowData.item"
           :label="getSelectGroupLabel(rowData.item)"
           hide-label
-          @input="$emit('toggleSelectGroup', rowData.item)"
+          @update:modelValue="$emit('toggleSelectGroup', rowData.item)"
         />
       </template>
       <template #avatar="rowData">
diff --git a/packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue b/packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
index 92c1283e931..727745abe52 100644
--- a/packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
+++ b/packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
@@ -27,20 +27,20 @@
           size="large"
           class="oc-ml-s"
           :label="$gettext('Select all spaces')"
-          :value="allSpacesSelected"
+          :model-value="allSpacesSelected"
           hide-label
-          @input="$emit('toggleSelectAllSpaces')"
+          @update:modelValue="$emit('toggleSelectAllSpaces')"
         />
       </template>
       <template #select="{ item }">
         <oc-checkbox
           class="oc-ml-s"
           size="large"
-          :value="isSpaceSelected(item)"
+          :model-value="isSpaceSelected(item)"
           :option="item"
           :label="getSelectSpaceLabel(item)"
           hide-label
-          @input="$emit('toggleSelectSpace', item)"
+          @update:modelValue="$emit('toggleSelectSpace', item)"
           @click.stop
         />
       </template>
diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
index 7d1d924ecf6..fae247a054c 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
@@ -41,6 +41,9 @@
 <script lang="ts">
 import { defineComponent } from 'vue'
 import UserInfoBox from './UserInfoBox.vue'
+import { PropType } from 'vue'
+import { User } from 'web-client/src/generated'
+
 export default defineComponent({
   name: 'DetailsPanel',
   components: {
@@ -48,8 +51,8 @@ export default defineComponent({
   },
   props: {
     user: {
-      type: Object,
-      required: true
+      type: Object as PropType<User>,
+      required: false
     },
     users: {
       type: Array,
diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
index 0f21c4da1c4..5ed222f2cc3 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
@@ -62,12 +62,13 @@
   </div>
 </template>
 <script lang="ts">
-import { defineComponent } from 'vue'
+import { defineComponent, PropType } from 'vue'
 import * as EmailValidator from 'email-validator'
 import UserInfoBox from './UserInfoBox.vue'
 import CompareSaveDialog from 'web-pkg/src/components/sideBar/CompareSaveDialog.vue'
 import QuotaSelect from 'web-pkg/src/components/QuotaSelect.vue'
 import { cloneDeep } from 'lodash-es'
+import { User } from 'web-client/src/generated'
 
 export default defineComponent({
   name: 'EditPanel',
@@ -78,8 +79,8 @@ export default defineComponent({
   },
   props: {
     user: {
-      type: Object,
-      required: true
+      type: Object as PropType<User>,
+      required: false
     },
     roles: {
       type: Array,
diff --git a/packages/web-app-admin-settings/src/components/Users/UsersList.vue b/packages/web-app-admin-settings/src/components/Users/UsersList.vue
index 6b0bfc5d992..fadace39179 100644
--- a/packages/web-app-admin-settings/src/components/Users/UsersList.vue
+++ b/packages/web-app-admin-settings/src/components/Users/UsersList.vue
@@ -24,20 +24,20 @@
           size="large"
           class="oc-ml-s"
           :label="$gettext('Select all users')"
-          :value="allUsersSelected"
+          :model-value="allUsersSelected"
           hide-label
-          @input="$emit('toggleSelectAllUsers')"
+          @update:modelValue="$emit('toggleSelectAllUsers')"
         />
       </template>
       <template #select="{ item }">
         <oc-checkbox
           class="oc-ml-s"
           size="large"
-          :value="selectedUsers"
+          :model-value="selectedUsers"
           :option="item"
           :label="getSelectUserLabel(item)"
           hide-label
-          @input="$emit('toggleSelectUser', item)"
+          @update:modelValue="$emit('toggleSelectUser', item)"
         />
       </template>
       <template #avatar="{ item }">
@@ -104,6 +104,7 @@ export default defineComponent({
       required: true
     }
   },
+  emits: ['unSelectAllUsers', 'toggleSelectAllUsers', 'toggleSelectUser'],
   setup(props, { emit }) {
     const showDetails = (user) => {
       emit('unSelectAllUsers')
diff --git a/packages/web-app-admin-settings/src/views/Users.vue b/packages/web-app-admin-settings/src/views/Users.vue
index 6f0d154f916..09f6c458666 100644
--- a/packages/web-app-admin-settings/src/views/Users.vue
+++ b/packages/web-app-admin-settings/src/views/Users.vue
@@ -213,7 +213,8 @@ export default defineComponent({
       loadResourcesTask,
       loadAdditionalUserDataTask,
       graphClient,
-      accessToken
+      accessToken,
+      listHeaderPosition
     }
   },
   data: function () {
diff --git a/packages/web-app-files/src/views/spaces/DriveRedirect.vue b/packages/web-app-files/src/views/spaces/DriveRedirect.vue
index 5e8efebbb3c..b9c6ea65b28 100644
--- a/packages/web-app-files/src/views/spaces/DriveRedirect.vue
+++ b/packages/web-app-files/src/views/spaces/DriveRedirect.vue
@@ -57,19 +57,17 @@ export default defineComponent({
       path: unref(itemPath)
     })
 
-    return (
-      router
-        .replace({
-          ...unref(route),
-          params: {
-            ...unref(route).params,
-            ...params
-          },
-          query
-        })
-        // avoid NavigationDuplicated error in console
-        .catch(() => {})
-    )
+    router
+      .replace({
+        ...unref(route),
+        params: {
+          ...unref(route).params,
+          ...params
+        },
+        query
+      })
+      // avoid NavigationDuplicated error in console
+      .catch(() => {})
   }
 })
 </script>
diff --git a/packages/web-pkg/src/composables/sideBar/useSideBar.ts b/packages/web-pkg/src/composables/sideBar/useSideBar.ts
index 55ebff88283..c049c715159 100644
--- a/packages/web-pkg/src/composables/sideBar/useSideBar.ts
+++ b/packages/web-pkg/src/composables/sideBar/useSideBar.ts
@@ -14,7 +14,7 @@ interface SideBarOptions {
 export const useSideBar = (options?: SideBarOptions): SideBarResult => {
   const eventBus = options?.bus || defaultEventBus
   const sideBarOpen = ref(false)
-  const sideBarActivePanel = ref(null)
+  const sideBarActivePanel = ref('')
   const toggleSideBarToken = eventBus.subscribe(SideBarEventTopics.toggle, () => {
     sideBarOpen.value = !unref(sideBarOpen)
   })
@@ -28,14 +28,14 @@ export const useSideBar = (options?: SideBarOptions): SideBarResult => {
   })
   const openSideBarWithPanelToken = eventBus.subscribe(
     SideBarEventTopics.openWithPanel,
-    (panelName) => {
+    (panelName: string) => {
       sideBarOpen.value = true
       sideBarActivePanel.value = panelName
     }
   )
   const setActiveSideBarPanelToken = eventBus.subscribe(
     SideBarEventTopics.setActivePanel,
-    (panelName) => {
+    (panelName: string) => {
       sideBarActivePanel.value = panelName
     }
   )
diff --git a/packages/web-runtime/src/compatConfig.ts b/packages/web-runtime/src/compatConfig.ts
index da4acba039f..4fea14206a9 100644
--- a/packages/web-runtime/src/compatConfig.ts
+++ b/packages/web-runtime/src/compatConfig.ts
@@ -16,30 +16,30 @@ export const compatConfig: CompatConfig = {
   // CONFIG_SILENT: false,
   // CONFIG_WHITESPACE: false,
   // CUSTOM_DIR: false,
-  // FILTERS: false,
-  // GLOBAL_DELETE: false,
+  FILTERS: false,
+  GLOBAL_DELETE: false,
   GLOBAL_EXTEND: false,
-  // GLOBAL_MOUNT: false,
-  // GLOBAL_MOUNT_CONTAINER: false,
-  // GLOBAL_OBSERVABLE: false,
-  // GLOBAL_PRIVATE_UTIL: false,
+  GLOBAL_MOUNT: false,
+  GLOBAL_MOUNT_CONTAINER: false,
+  GLOBAL_OBSERVABLE: false,
+  GLOBAL_PRIVATE_UTIL: false,
   GLOBAL_PROTOTYPE: false,
   GLOBAL_SET: false,
   INSTANCE_ATTRS_CLASS_STYLE: false,
   INSTANCE_CHILDREN: false,
   INSTANCE_DELETE: false,
-  // INSTANCE_DESTROY: false,
+  INSTANCE_DESTROY: false,
   INSTANCE_EVENT_EMITTER: false,
   INSTANCE_EVENT_HOOKS: false,
   // INSTANCE_LISTENERS: false,
   INSTANCE_SCOPED_SLOTS: false,
-  // INSTANCE_SET: false,
+  INSTANCE_SET: false,
   OPTIONS_BEFORE_DESTROY: false,
-  // OPTIONS_DATA_FN: false,
+  OPTIONS_DATA_FN: false,
   OPTIONS_DATA_MERGE: false,
   OPTIONS_DESTROYED: false,
   // PRIVATE_APIS: false,
-  // PROPS_DEFAULT_THIS: false,
+  PROPS_DEFAULT_THIS: false,
   RENDER_FUNCTION: false,
   // TRANSITION_CLASSES: false,
   // TRANSITION_GROUP_ROOT: false,
diff --git a/packages/web-runtime/src/store/spaces.ts b/packages/web-runtime/src/store/spaces.ts
index 857d8ee2989..dfea3f2cb67 100644
--- a/packages/web-runtime/src/store/spaces.ts
+++ b/packages/web-runtime/src/store/spaces.ts
@@ -1,5 +1,5 @@
 import { buildSpace, isProjectSpaceResource, SpaceResource } from 'web-client/src/helpers'
-import Vue, { Ref } from 'vue'
+import { Ref } from 'vue'
 import { set, has } from 'lodash-es'
 import { unref } from 'vue'
 import { buildSpaceShare } from 'web-client/src/helpers/share'