From fd3c8eb57318ad7bdf2b73873650d20d1e69f7a6 Mon Sep 17 00:00:00 2001 From: elizavetaRa Date: Tue, 8 Mar 2022 21:29:54 +0100 Subject: [PATCH 1/2] hover with background-hover --- .../src/components/FilesList/ContextActions.vue | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/web-app-files/src/components/FilesList/ContextActions.vue b/packages/web-app-files/src/components/FilesList/ContextActions.vue index 6279767e3f1..448a36ca1cd 100644 --- a/packages/web-app-files/src/components/FilesList/ContextActions.vue +++ b/packages/web-app-files/src/components/FilesList/ContextActions.vue @@ -210,6 +210,10 @@ export default { li { padding: 6px; + &:hover { + background-color: var(--oc-color-background-hover); + border-radius: 4px; + } } > li { @@ -224,12 +228,6 @@ export default { vertical-align: top; width: 100%; text-align: left; - - span:hover, - &:hover { - color: var(--oc-color-swatch-passive-hover) !important; - text-decoration: underline !important; - } } } From dcb6c5488735735f5a6fdaf6c95146abb79248fb Mon Sep 17 00:00:00 2001 From: Pascal Wengerter Date: Wed, 9 Mar 2022 12:41:10 +0100 Subject: [PATCH 2/2] Add changelog item && switch to rounded-corners helper class --- .../enhancement-contextmenu-hover-background | 7 +++ .../components/FilesList/ContextActions.vue | 3 +- .../__snapshots__/ContextActions.spec.js.snap | 52 +++++++++---------- 3 files changed, 34 insertions(+), 28 deletions(-) create mode 100644 changelog/unreleased/enhancement-contextmenu-hover-background diff --git a/changelog/unreleased/enhancement-contextmenu-hover-background b/changelog/unreleased/enhancement-contextmenu-hover-background new file mode 100644 index 00000000000..106ed991521 --- /dev/null +++ b/changelog/unreleased/enhancement-contextmenu-hover-background @@ -0,0 +1,7 @@ +Enhancement: Contextmenu background hover + +We've added a background hover color for contextmenu actions. + +https://github.com/owncloud/web/pull/6553 +https://github.com/owncloud/web/pull/6559 +https://github.com/owncloud/web/issues/6560 diff --git a/packages/web-app-files/src/components/FilesList/ContextActions.vue b/packages/web-app-files/src/components/FilesList/ContextActions.vue index 448a36ca1cd..cff383fefc5 100644 --- a/packages/web-app-files/src/components/FilesList/ContextActions.vue +++ b/packages/web-app-files/src/components/FilesList/ContextActions.vue @@ -12,7 +12,7 @@ :key="`section-${section.name}-action-${actionIndex}`" :action="action" :items="items" - class="oc-files-context-action oc-px-s" + class="oc-files-context-action oc-px-s oc-rounded" /> @@ -212,7 +212,6 @@ export default { padding: 6px; &:hover { background-color: var(--oc-color-background-hover); - border-radius: 4px; } } diff --git a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap index 60e07dd023f..91a80fa24af 100644 --- a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap @@ -3,59 +3,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = `
-
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • @@ -66,59 +66,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = ` exports[`ContextActions menu items renders a list of actions for a folder 1`] = `
    -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -