From 3f3af7c3ba38963d5f4bd33e238e29eff1e2b9d4 Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 14:32:28 +0100
Subject: [PATCH 01/15] Add details panel for unique trashed and multi select

---
 .../SideBar/Details/FileDetails.vue           | 37 +++++++++++++++++--
 .../SideBar/Details/FileDetailsMultiple.vue   | 14 +++++--
 .../composables/extensions/useFileSideBars.ts | 13 +++----
 .../ResourceDetails.spec.ts.snap              |  1 +
 4 files changed, 50 insertions(+), 15 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index 08c5781fd30..82d5127bcd6 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -33,6 +33,12 @@
       >
         <col class="oc-width-1-3" />
         <col class="oc-width-2-3" />
+        <tr v-if="hasDeletionDate" data-testid="delete-timestamp">
+          <th scope="col" class="oc-pr-s oc-font-semibold" v-text="$gettext('Deleted at')" />
+          <td>
+            <span v-text="capitalizedDeletionDate"></span>
+          </td>
+        </tr>
         <tr v-if="hasTimestamp" data-testid="timestamp">
           <th scope="col" class="oc-pr-s oc-font-semibold" v-text="$gettext('Last modified')" />
           <td>
@@ -131,7 +137,8 @@ import {
   useCapabilityStore,
   useConfigStore,
   useClientService,
-  useResourcesStore
+  useResourcesStore,
+  formatDateFromJSDate
 } from '@ownclouders/web-pkg'
 import upperFirst from 'lodash-es/upperFirst'
 import { isShareResource, ShareTypes } from '@ownclouders/web-client/src/helpers/share'
@@ -167,6 +174,11 @@ export default defineComponent({
       type: Boolean,
       required: false,
       default: true
+    },
+    versionsEnabled: {
+      type: Boolean,
+      required: false,
+      default: true
     }
   },
   setup(props) {
@@ -175,6 +187,7 @@ export default defineComponent({
     const capabilityStore = useCapabilityStore()
     const clientService = useClientService()
     const { getMatchingSpace } = useGetMatchingSpace()
+
     const language = useGettext()
 
     const resourcesStore = useResourcesStore()
@@ -184,6 +197,7 @@ export default defineComponent({
 
     const resource = inject<Ref<Resource>>('resource')
     const space = inject<Ref<SpaceResource>>('space')
+
     const previewService = usePreviewService()
     const preview = ref(undefined)
 
@@ -252,8 +266,11 @@ export default defineComponent({
       () => {
         if (unref(resource)) {
           loadPreviewTask.perform(unref(resource))
-
-          if (!unref(resource).isFolder && !unref(publicLinkContextReady)) {
+          if (
+            !props.versionsEnabled &&
+            !unref(resource).isFolder &&
+            !unref(publicLinkContextReady)
+          ) {
             loadVersions(unref(resource).fileId)
           }
         }
@@ -270,6 +287,15 @@ export default defineComponent({
       return props.tagsEnabled && capabilityStore.filesTags
     })
 
+    const hasDeletionDate = computed(() => {
+      return unref(resource).ddate
+    })
+
+    const capitalizedDeletionDate = computed(() => {
+      const displayDate = formatDateFromJSDate(new Date(unref(resource).ddate), language.current)
+      return upperFirst(displayDate)
+    })
+
     return {
       user,
       preview,
@@ -277,6 +303,8 @@ export default defineComponent({
       space,
       resource,
       hasTags,
+      hasDeletionDate,
+      capitalizedDeletionDate,
       isPreviewLoading,
       ancestorMetaData,
       sharedAncestor,
@@ -294,7 +322,8 @@ export default defineComponent({
         this.ownerDisplayName ||
         this.showSize ||
         this.showShares ||
-        this.showVersions
+        this.showVersions ||
+        this.hasDeletionDate
       )
     },
     sharedViaTooltip() {
diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
index 1636d62c20f..f27fac95fc7 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
@@ -20,7 +20,7 @@
           <th scope="col" class="oc-pr-s oc-font-semibold" v-text="spacesText" />
           <td v-text="spacesCount" />
         </tr>
-        <tr data-testid="size">
+        <tr v-if="hasSize" data-testid="size">
           <th scope="col" class="oc-pr-s oc-font-semibold" v-text="sizeText" />
           <td v-text="sizeValue" />
         </tr>
@@ -29,7 +29,7 @@
   </div>
 </template>
 <script lang="ts">
-import { defineComponent } from 'vue'
+import { computed, defineComponent, unref } from 'vue'
 import { storeToRefs } from 'pinia'
 import { formatFileSize, useResourcesStore } from '@ownclouders/web-pkg'
 
@@ -42,7 +42,11 @@ export default defineComponent({
     const resourcesStore = useResourcesStore()
     const { selectedResources } = storeToRefs(resourcesStore)
 
-    return { selectedResources }
+    const hasSize = computed(() => {
+      return unref(selectedResources).some((resource) => resource.hasOwnProperty('size'))
+    })
+
+    return { hasSize, selectedResources }
   },
   computed: {
     selectedFilesCount() {
@@ -60,7 +64,7 @@ export default defineComponent({
     },
     sizeValue() {
       let size = 0
-      this.selectedResources.forEach((i) => (size += parseInt(i.size.toString())))
+      this.selectedResources.forEach((i) => (size += parseInt(i?.size?.toString())))
       return formatFileSize(size, this.$language.current)
     },
     sizeText() {
@@ -110,11 +114,13 @@ export default defineComponent({
     .preview-icon {
       display: inline-block;
     }
+
     .preview-text {
       display: block;
     }
   }
 }
+
 .details-table {
   text-align: left;
 
diff --git a/packages/web-app-files/src/composables/extensions/useFileSideBars.ts b/packages/web-app-files/src/composables/extensions/useFileSideBars.ts
index d665c31abb4..94511bfdfea 100644
--- a/packages/web-app-files/src/composables/extensions/useFileSideBars.ts
+++ b/packages/web-app-files/src/composables/extensions/useFileSideBars.ts
@@ -95,14 +95,13 @@ export const useSideBarPanels = () => {
             component: FileDetails,
             componentAttrs: ({ items }) => ({
               previewEnabled: unref(isFilesAppActive),
-              tagsEnabled: !isPersonalSpaceRoot(items[0])
+              tagsEnabled:
+                !isPersonalSpaceRoot(items[0]) &&
+                !isLocationTrashActive(router, 'files-trash-generic'),
+              versionsEnabled: !isLocationTrashActive(router, 'files-trash-generic')
             }),
-            isRoot: () => !isLocationTrashActive(router, 'files-trash-generic'),
+            isRoot: () => true,
             isVisible: ({ items }) => {
-              if (isLocationTrashActive(router, 'files-trash-generic')) {
-                // details panel is not available in trash
-                return false
-              }
               if (items?.length !== 1) {
                 return false
               }
@@ -148,7 +147,7 @@ export const useSideBarPanels = () => {
             icon: 'slideshow-3',
             title: () => $gettext('Actions'),
             component: FileActions,
-            isRoot: () => isLocationTrashActive(router, 'files-trash-generic'),
+            isRoot: () => false,
             isVisible: ({ items }) => {
               if (items?.length !== 1) {
                 return false
diff --git a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap
index de7d3c7023e..e050560eae0 100644
--- a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap
+++ b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap
@@ -19,6 +19,7 @@ exports[`ResourceDetails component > renders resource details correctly 1`] = `
         <table data-v-5080a6a4="" class="details-table oc-width-1-1" aria-label="Overview of the information about the selected file">
           <col data-v-5080a6a4="" class="oc-width-1-3">
           <col data-v-5080a6a4="" class="oc-width-2-3">
+          <!--v-if-->
           <tr data-v-5080a6a4="" data-testid="timestamp">
             <th data-v-5080a6a4="" scope="col" class="oc-pr-s oc-font-semibold">Last modified</th>
             <td data-v-5080a6a4=""><span data-v-5080a6a4="">Oct 21, 2015, 7:28 AM</span></td>

From 8f16a939e131bfd447d71fa36a67294f9ffb34ae Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 14:42:04 +0100
Subject: [PATCH 02/15] Fix wrong condition

---
 .../src/components/SideBar/Details/FileDetails.vue              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index 82d5127bcd6..4cdcb7dff21 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -267,7 +267,7 @@ export default defineComponent({
         if (unref(resource)) {
           loadPreviewTask.perform(unref(resource))
           if (
-            !props.versionsEnabled &&
+            props.versionsEnabled &&
             !unref(resource).isFolder &&
             !unref(publicLinkContextReady)
           ) {

From 565a2095df3dede65c035f298e10bfc38769229f Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 14:45:17 +0100
Subject: [PATCH 03/15] Add changelog item

---
 .../unreleased/enhancement-add-details-panel-to-trash     | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 changelog/unreleased/enhancement-add-details-panel-to-trash

diff --git a/changelog/unreleased/enhancement-add-details-panel-to-trash b/changelog/unreleased/enhancement-add-details-panel-to-trash
new file mode 100644
index 00000000000..41ec75a6ba1
--- /dev/null
+++ b/changelog/unreleased/enhancement-add-details-panel-to-trash
@@ -0,0 +1,8 @@
+Enhancement: Add details panel to trash
+
+We've added the details panel to the right side bar, when the user selects a resource in the trash.
+We also added a panel for multi select.
+
+https://github.com/owncloud/web/pull/10624
+https://github.com/owncloud/web/issues/10620
+https://github.com/owncloud/web/issues/10616

From 6a6d8d54a8e21451f3d04671e1dceaadbec63191 Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 15:25:09 +0100
Subject: [PATCH 04/15] Build webdavUrl with space

---
 .../components/SideBar/Details/FileDetails.vue  |  2 +-
 .../src/components/SideBar/WebDavDetails.vue    | 17 ++++++++++-------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index 4cdcb7dff21..b371f85d458 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -90,7 +90,7 @@
           <th scope="col" class="oc-pr-s oc-font-semibold" v-text="$gettext('Size')" />
           <td v-text="resourceSize" />
         </tr>
-        <web-dav-details v-if="showWebDavDetails" />
+        <web-dav-details v-if="showWebDavDetails" :space="space" />
         <tr v-if="showVersions" data-testid="versionsInfo">
           <th scope="col" class="oc-pr-s oc-font-semibold" v-text="$gettext('Versions')" />
           <td>
diff --git a/packages/web-pkg/src/components/SideBar/WebDavDetails.vue b/packages/web-pkg/src/components/SideBar/WebDavDetails.vue
index 19dcb80629c..faccf00d746 100644
--- a/packages/web-pkg/src/components/SideBar/WebDavDetails.vue
+++ b/packages/web-pkg/src/components/SideBar/WebDavDetails.vue
@@ -38,16 +38,19 @@
 </template>
 
 <script lang="ts">
-import { defineComponent, inject, ref, Ref, computed, unref } from 'vue'
+import { defineComponent, inject, ref, Ref, computed, unref, PropType } from 'vue'
 import { urlJoin } from '@ownclouders/web-client/src/utils'
-import { Resource } from '@ownclouders/web-client'
-import { useConfigStore } from '../../composables'
+import { Resource, SpaceResource } from '@ownclouders/web-client'
 
 export default defineComponent({
   name: 'WebDavDetails',
-  setup() {
-    const configStore = useConfigStore()
-
+  props: {
+    space: {
+      type: Object as PropType<SpaceResource>,
+      required: true
+    }
+  },
+  setup(props) {
     const resource = inject<Ref<Resource>>('resource')
     const copiedIcon = 'check'
     const copyIcon = 'file-copy'
@@ -55,7 +58,7 @@ export default defineComponent({
     const copyWebDAVUrlIcon = ref(copyIcon)
 
     const webDavUrl = computed(() => {
-      return urlJoin(configStore.serverUrl, unref(resource).webDavPath)
+      return urlJoin(props.space.root.webDavUrl, unref(resource).path)
     })
 
     const copyWebDAVPathToClipboard = () => {

From 00cb92b5df38201c29f0faa8ddb3e685bbe3918d Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 18:31:23 +0100
Subject: [PATCH 05/15] Fix types

---
 .../src/components/SideBar/Details/FileDetails.vue          | 6 +++++-
 .../src/components/SideBar/Spaces/Details/SpaceDetails.vue  | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index b371f85d458..087775793ac 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -255,7 +255,11 @@ export default defineComponent({
        * webDavPath might not be set when user is navigating on public link,
        * even if the user is authenticated and the file owner.
        */
-      return resourcesStore.areWebDavDetailsShown && unref(resource).webDavPath
+      return (
+        resourcesStore.areWebDavDetailsShown &&
+        unref(space)?.root?.webDavUrl &&
+        unref(resource)?.webDavPath
+      )
     })
     const formatDateRelative = (date) => {
       return formatRelativeDateFromJSDate(new Date(date), language.current)
diff --git a/packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue b/packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue
index eeb14a035b4..bb199214d6e 100644
--- a/packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue
+++ b/packages/web-pkg/src/components/SideBar/Spaces/Details/SpaceDetails.vue
@@ -66,7 +66,7 @@
           <space-quota :space-quota="resource.spaceQuota" />
         </td>
       </tr>
-      <web-dav-details v-if="showWebDavDetails" />
+      <web-dav-details v-if="showWebDavDetails" :space="resource" />
       <portal-target
         name="app.files.sidebar.space.details.table"
         :slot-props="{ space: resource, resource }"

From 1c4258fa0ccaaa3f04453db7781b52ddffc75a46 Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 19:24:16 +0100
Subject: [PATCH 06/15] Fix rendering multiple (even wrong) panels after each
 other, because current folder is not updated propably and might be still
 there when navigation to trashbin or spaces

---
 .../src/components/SideBar/Details/FileDetails.vue              | 1 -
 packages/web-pkg/src/components/SideBar/FileSideBar.vue         | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index 087775793ac..a529402b10f 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -257,7 +257,6 @@ export default defineComponent({
        */
       return (
         resourcesStore.areWebDavDetailsShown &&
-        unref(space)?.root?.webDavUrl &&
         unref(resource)?.webDavPath
       )
     })
diff --git a/packages/web-pkg/src/components/SideBar/FileSideBar.vue b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
index cf40c3401ee..57f1ae89bb3 100644
--- a/packages/web-pkg/src/components/SideBar/FileSideBar.vue
+++ b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
@@ -100,7 +100,7 @@ export default defineComponent({
         return {
           root: props.space,
           parent: null,
-          items: unref(currentFolder)?.id ? [unref(currentFolder)] : []
+          items: []
         }
       }
       return {

From 27ae611b626b44a6671d2913946a73e3527b15c2 Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 19:46:32 +0100
Subject: [PATCH 07/15] Add real fix

---
 .../web-pkg/src/components/SideBar/FileSideBar.vue |  3 ++-
 packages/web-runtime/src/App.vue                   | 14 ++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/packages/web-pkg/src/components/SideBar/FileSideBar.vue b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
index 57f1ae89bb3..50283ba11d2 100644
--- a/packages/web-pkg/src/components/SideBar/FileSideBar.vue
+++ b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
@@ -96,11 +96,12 @@ export default defineComponent({
     const { selectedResources } = useSelectedResources()
 
     const panelContext = computed<SideBarPanelContext<SpaceResource, Resource, Resource>>(() => {
+      console.log('currentFolderChange', unref(currentFolder))
       if (unref(selectedResources).length === 0) {
         return {
           root: props.space,
           parent: null,
-          items: []
+          items: unref(currentFolder)?.id ? [unref(currentFolder)] : []
         }
       }
       return {
diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue
index 1b527cc0700..c63eecaa884 100644
--- a/packages/web-runtime/src/App.vue
+++ b/packages/web-runtime/src/App.vue
@@ -40,14 +40,16 @@ export default defineComponent({
     watch(
       () => unref(activeRoute),
       (newRoute, oldRoute) => {
-        const getAppFromRoute = (route: RouteLocation): string => {
-          return route?.path?.split('/')?.[1]
+        const getAppContextFromRoute = (route: RouteLocation): string => {
+          return route?.path?.split('/').slice(1, 4)
         }
 
-        const oldApp = getAppFromRoute(oldRoute)
-        const newApp = getAppFromRoute(newRoute)
+        const oldAppContext = getAppContextFromRoute(oldRoute)
+        const newAppContext = getAppContextFromRoute(newRoute)
 
-        if (oldApp === newApp) {
+        console.log(oldAppContext, newAppContext)
+
+        if (oldAppContext === newAppContext) {
           return
         }
 
@@ -56,7 +58,7 @@ export default defineComponent({
         }
 
         /*
-         * If app has been changed and no file context is set, we will reset current folder.
+         * If app context has been changed and no file context is set, we will reset current folder.
          */
         resourcesStore.setCurrentFolder(null)
       }

From 697c665d0f43179e7a0ef44adff24e5586c8be6a Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 19:51:09 +0100
Subject: [PATCH 08/15] Lint

---
 .../src/components/SideBar/Details/FileDetails.vue           | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index a529402b10f..6453cc2ac44 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -255,10 +255,7 @@ export default defineComponent({
        * webDavPath might not be set when user is navigating on public link,
        * even if the user is authenticated and the file owner.
        */
-      return (
-        resourcesStore.areWebDavDetailsShown &&
-        unref(resource)?.webDavPath
-      )
+      return resourcesStore.areWebDavDetailsShown && unref(resource)?.webDavPath
     })
     const formatDateRelative = (date) => {
       return formatRelativeDateFromJSDate(new Date(date), language.current)

From 312e31eec3e4e96e9c5cf3f9610505da033e300d Mon Sep 17 00:00:00 2001
From: Alex <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 20:38:58 +0100
Subject: [PATCH 09/15] Fix types

---
 packages/web-runtime/src/App.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue
index c63eecaa884..bea786674db 100644
--- a/packages/web-runtime/src/App.vue
+++ b/packages/web-runtime/src/App.vue
@@ -40,7 +40,7 @@ export default defineComponent({
     watch(
       () => unref(activeRoute),
       (newRoute, oldRoute) => {
-        const getAppContextFromRoute = (route: RouteLocation): string => {
+        const getAppContextFromRoute = (route: RouteLocation): string[] => {
           return route?.path?.split('/').slice(1, 4)
         }
 

From 0e7aebe086937b235b74dc82f7e0af85aee66136 Mon Sep 17 00:00:00 2001
From: Alex <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 21:20:37 +0100
Subject: [PATCH 10/15] remove useless added code

---
 .../src/components/SideBar/Details/FileDetails.vue              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
index 6453cc2ac44..b371f85d458 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
@@ -255,7 +255,7 @@ export default defineComponent({
        * webDavPath might not be set when user is navigating on public link,
        * even if the user is authenticated and the file owner.
        */
-      return resourcesStore.areWebDavDetailsShown && unref(resource)?.webDavPath
+      return resourcesStore.areWebDavDetailsShown && unref(resource).webDavPath
     })
     const formatDateRelative = (date) => {
       return formatRelativeDateFromJSDate(new Date(date), language.current)

From a55cfaad14d4015b9175245da9bb473991b11e1f Mon Sep 17 00:00:00 2001
From: Alex <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 21:22:59 +0100
Subject: [PATCH 11/15] safe accumulation

---
 .../src/components/SideBar/Details/FileDetailsMultiple.vue      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
index f27fac95fc7..48b5177d404 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
@@ -64,7 +64,7 @@ export default defineComponent({
     },
     sizeValue() {
       let size = 0
-      this.selectedResources.forEach((i) => (size += parseInt(i?.size?.toString())))
+      this.selectedResources.forEach((i) => (size += parseInt(i.size?.toString() || 0)))
       return formatFileSize(size, this.$language.current)
     },
     sizeText() {

From cee3b3fe398a5af3f10eba61307eb77e130f3160 Mon Sep 17 00:00:00 2001
From: Alex <jan.alexander.ackermann@outlook.com>
Date: Fri, 15 Mar 2024 21:23:57 +0100
Subject: [PATCH 12/15] fix type

---
 .../src/components/SideBar/Details/FileDetailsMultiple.vue      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
index 48b5177d404..0584c192a79 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
@@ -64,7 +64,7 @@ export default defineComponent({
     },
     sizeValue() {
       let size = 0
-      this.selectedResources.forEach((i) => (size += parseInt(i.size?.toString() || 0)))
+      this.selectedResources.forEach((i) => (size += parseInt(i.size?.toString() || '0')))
       return formatFileSize(size, this.$language.current)
     },
     sizeText() {

From 3c2f90142fe1dfa575596e59c75670246026f85a Mon Sep 17 00:00:00 2001
From: Alex <jan.alexander.ackermann@outlook.com>
Date: Mon, 18 Mar 2024 09:34:52 +0100
Subject: [PATCH 13/15] Update FileDetailsMultiple.vue

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
---
 .../src/components/SideBar/Details/FileDetailsMultiple.vue      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
index 0584c192a79..04c5ef4aabf 100644
--- a/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
@@ -43,7 +43,7 @@ export default defineComponent({
     const { selectedResources } = storeToRefs(resourcesStore)
 
     const hasSize = computed(() => {
-      return unref(selectedResources).some((resource) => resource.hasOwnProperty('size'))
+      return unref(selectedResources).some((resource) => Object.hasOwn(resource, 'size'))
     })
 
     return { hasSize, selectedResources }

From 92ca2df4ac13f4cd464790b6897f4f79e100157c Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Mon, 18 Mar 2024 11:38:22 +0100
Subject: [PATCH 14/15] React on code review

---
 packages/web-pkg/src/components/SideBar/FileSideBar.vue | 1 -
 packages/web-runtime/src/App.vue                        | 5 ++---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/web-pkg/src/components/SideBar/FileSideBar.vue b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
index 50283ba11d2..cf40c3401ee 100644
--- a/packages/web-pkg/src/components/SideBar/FileSideBar.vue
+++ b/packages/web-pkg/src/components/SideBar/FileSideBar.vue
@@ -96,7 +96,6 @@ export default defineComponent({
     const { selectedResources } = useSelectedResources()
 
     const panelContext = computed<SideBarPanelContext<SpaceResource, Resource, Resource>>(() => {
-      console.log('currentFolderChange', unref(currentFolder))
       if (unref(selectedResources).length === 0) {
         return {
           root: props.space,
diff --git a/packages/web-runtime/src/App.vue b/packages/web-runtime/src/App.vue
index bea786674db..c0de68cfa5c 100644
--- a/packages/web-runtime/src/App.vue
+++ b/packages/web-runtime/src/App.vue
@@ -19,6 +19,7 @@ import { eventBus, useResourcesStore, useRouter, useThemeStore } from '@owncloud
 import { useHead } from './composables/head'
 import { RouteLocation } from 'vue-router'
 import { storeToRefs } from 'pinia'
+import { isEqual } from 'lodash-es'
 
 export default defineComponent({
   components: {
@@ -47,9 +48,7 @@ export default defineComponent({
         const oldAppContext = getAppContextFromRoute(oldRoute)
         const newAppContext = getAppContextFromRoute(newRoute)
 
-        console.log(oldAppContext, newAppContext)
-
-        if (oldAppContext === newAppContext) {
+        if (isEqual(oldAppContext, newAppContext)) {
           return
         }
 

From 00ff0acd28e66b86864aaf774fb9122172b3ce5d Mon Sep 17 00:00:00 2001
From: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Date: Mon, 18 Mar 2024 12:07:13 +0100
Subject: [PATCH 15/15] Center no selection panels

---
 .../src/components/Groups/SideBar/DetailsPanel.vue            | 4 +++-
 .../src/components/Users/SideBar/DetailsPanel.vue             | 2 +-
 .../src/components/SideBar/Spaces/SpaceNoSelection.vue        | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/web-app-admin-settings/src/components/Groups/SideBar/DetailsPanel.vue b/packages/web-app-admin-settings/src/components/Groups/SideBar/DetailsPanel.vue
index cbdba2ffd9d..ae3e1e4fe39 100644
--- a/packages/web-app-admin-settings/src/components/Groups/SideBar/DetailsPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Groups/SideBar/DetailsPanel.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="oc-mt-xl">
-    <div v-if="noGroups" class="oc-flex group-info">
+    <div v-if="noGroups" class="oc-flex group-info oc-text-center">
       <oc-icon name="group-2" size="xxlarge" />
       <p v-translate>Select a group to view details</p>
     </div>
@@ -59,9 +59,11 @@ export default defineComponent({
   align-items: center;
   flex-direction: column;
 }
+
 .group-info-display-name {
   font-size: 1.5rem;
 }
+
 .details-table {
   text-align: left;
 
diff --git a/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue b/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
index 234b6f6369e..780ca6dc1ba 100644
--- a/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
+++ b/packages/web-app-admin-settings/src/components/Users/SideBar/DetailsPanel.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="oc-mt-xl">
-    <div v-if="noUsers" class="oc-flex user-info">
+    <div v-if="noUsers" class="oc-flex user-info oc-text-center">
       <oc-icon name="user" size="xxlarge" />
       <p v-translate>Select a user to view details</p>
     </div>
diff --git a/packages/web-pkg/src/components/SideBar/Spaces/SpaceNoSelection.vue b/packages/web-pkg/src/components/SideBar/Spaces/SpaceNoSelection.vue
index 4f6608fb1b4..6042f607b6d 100644
--- a/packages/web-pkg/src/components/SideBar/Spaces/SpaceNoSelection.vue
+++ b/packages/web-pkg/src/components/SideBar/Spaces/SpaceNoSelection.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="oc-mt-xl">
-    <div class="oc-flex space-info">
+    <div class="oc-flex space-info oc-text-center">
       <oc-icon name="layout-grid" size="xxlarge" />
       <p v-translate>Select a space to view details</p>
     </div>