diff --git a/__fixtures__/sidebarNavItems.js b/__fixtures__/sidebarNavItems.js index 0a99dc26593..ce8cd1cda9d 100644 --- a/__fixtures__/sidebarNavItems.js +++ b/__fixtures__/sidebarNavItems.js @@ -27,4 +27,3 @@ export default [ active: false } ] - diff --git a/changelog/unreleased/bugfix-iframe-border b/changelog/unreleased/bugfix-iframe-border new file mode 100644 index 00000000000..d3d35e121fe --- /dev/null +++ b/changelog/unreleased/bugfix-iframe-border @@ -0,0 +1,6 @@ +Bugfix: Remove iFrame border + +We fixed a UI issue which showed small borders around iFrames, e.g. in the external app. + +https://github.com/owncloud/web/issues/6555 +https://github.com/owncloud/web/pull/6573 diff --git a/changelog/unreleased/enhancement-shares-overview b/changelog/unreleased/enhancement-shares-overview index 59d4ead7a5f..e8f97448343 100644 --- a/changelog/unreleased/enhancement-shares-overview +++ b/changelog/unreleased/enhancement-shares-overview @@ -6,4 +6,6 @@ In the process, we have also renamed the "All files" page to the "Personal" page this is the user's personal space since shares (and potentially other shared spaces) live elsewhere. https://github.com/owncloud/web/issues/6440 +https://github.com/owncloud/web/issues/6570 https://github.com/owncloud/web/pull/6512 +https://github.com/owncloud/web/pull/6573 diff --git a/package.json b/package.json index 4329f64732c..ae4723b2002 100644 --- a/package.json +++ b/package.json @@ -124,7 +124,7 @@ "ts-jest": "^27.1.3", "ts-node": "^10.5.0", "tslib": "^2.2.0", - "typescript": "^4.5.5", + "typescript": "^4.6.2", "url-search-params-polyfill": "^8.0.0", "vue-jest": "^3.0.7", "vue-template-compiler": "^2.6.12", diff --git a/packages/web-app-files/src/components/AppBar/SharesNavigation.vue b/packages/web-app-files/src/components/AppBar/SharesNavigation.vue index dcb84503115..d203c34a941 100644 --- a/packages/web-app-files/src/components/AppBar/SharesNavigation.vue +++ b/packages/web-app-files/src/components/AppBar/SharesNavigation.vue @@ -4,11 +4,11 @@
  • +
  • @@ -20,10 +20,15 @@
  • + + +
  • @@ -40,8 +45,9 @@ import { locationSharesWithMe, locationSharesWithOthers } from '../../router/shares' -import { computed, getCurrentInstance } from '@vue/composition-api' +import { computed, getCurrentInstance, unref } from '@vue/composition-api' import { useRouter } from 'web-pkg/src/composables' +import { useActiveLocation } from '../../composables' export default { setup() { @@ -55,21 +61,33 @@ export default { routes[route.name] = router.getRoutes().find((r) => r.name === route.name) return routes }, {}) + const sharesWithMeActive = useActiveLocation(isLocationSharesActive, locationSharesWithMe.name) + const sharesWithOthersActive = useActiveLocation( + isLocationSharesActive, + locationSharesWithOthers.name + ) + const sharesViaLinkActive = useActiveLocation( + isLocationSharesActive, + locationSharesViaLink.name + ) const navItems = computed(() => [ { + icon: 'share-forward', to: sharesRoutes[locationSharesWithMe.name].path, text: $gettext('Shared with me'), - active: isLocationSharesActive(router, 'files-shares-with-me') + active: unref(sharesWithMeActive) }, { + icon: 'reply', to: sharesRoutes[locationSharesWithOthers.name].path, text: $gettext('Shared with others'), - active: isLocationSharesActive(router, 'files-shares-with-others') + active: unref(sharesWithOthersActive) }, { + icon: 'link', to: sharesRoutes[locationSharesViaLink.name].path, text: $gettext('Shared via link'), - active: isLocationSharesActive(router, 'files-shares-via-link') + active: unref(sharesViaLinkActive) } ]) return { @@ -79,7 +97,35 @@ export default { } diff --git a/packages/web-app-files/src/components/AppBar/ViewOptions.vue b/packages/web-app-files/src/components/AppBar/ViewOptions.vue index 6190cc8faf8..ca362c9e69a 100644 --- a/packages/web-app-files/src/components/AppBar/ViewOptions.vue +++ b/packages/web-app-files/src/components/AppBar/ViewOptions.vue @@ -1,5 +1,5 @@