From 4c538dd75d87dc689077f66c8eb54f0d7d01154f Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Mon, 14 Mar 2022 16:41:39 +0100 Subject: [PATCH 01/15] Redesign New Button to fit Figma --- .../src/components/AppBar/CreateAndUpload.vue | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue b/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue index d275e02ba5e..b8c645688f2 100644 --- a/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue +++ b/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue @@ -6,11 +6,11 @@ key="new-file-menu-btn-enabled" v-oc-tooltip="newButtonTooltip" :aria-label="newButtonAriaLabel" - variation="inverse" + variation="raw" :disabled="uploadOrFileCreationBlocked" class="oc-background-primary-gradient" > - + New From ab1e8f11e7429971c1dcbef8ddc0b0a22c8d470e Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Tue, 15 Mar 2022 15:57:36 +0100 Subject: [PATCH 06/15] Improve AppBar / BatchActions / SizeInfo for selection Linting & Update tests Fixes after rebase --- .../src/components/ActionMenuItem.vue | 16 +++++- .../src/components/AppBar/AppBar.vue | 8 ++- .../AppBar/SelectedResources/SizeInfo.vue | 30 ++++++----- .../web-app-files/src/components/Trashbin.vue | 1 + .../__snapshots__/ContextActions.spec.js.snap | 52 +++++++++---------- .../__snapshots__/Trashbin.spec.js.snap | 2 +- .../__snapshots__/PublicFiles.spec.ts.snap | 2 +- .../views/__snapshots__/Trashbin.spec.js.snap | 2 +- .../SharedWithOthers.spec.js.snap | 2 +- 9 files changed, 70 insertions(+), 45 deletions(-) diff --git a/packages/web-app-files/src/components/ActionMenuItem.vue b/packages/web-app-files/src/components/ActionMenuItem.vue index aebd5d6a3bc..3a792d404f8 100644 --- a/packages/web-app-files/src/components/ActionMenuItem.vue +++ b/packages/web-app-files/src/components/ActionMenuItem.vue @@ -3,8 +3,10 @@ + diff --git a/packages/web-app-files/src/components/AppBar/AppBar.vue b/packages/web-app-files/src/components/AppBar/AppBar.vue index 05e8b8c9e67..bd74de70aa8 100644 --- a/packages/web-app-files/src/components/AppBar/AppBar.vue +++ b/packages/web-app-files/src/components/AppBar/AppBar.vue @@ -44,8 +44,12 @@ @error="onFileError" @progress="onFileProgress" /> - - + + diff --git a/packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue b/packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue index e5c413f2191..f72afb3ca91 100644 --- a/packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue +++ b/packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue @@ -1,11 +1,21 @@ @@ -66,3 +67,8 @@ export default { } } + diff --git a/packages/web-app-files/src/components/Trashbin.vue b/packages/web-app-files/src/components/Trashbin.vue index 11fa15ac363..3ba8896fbcc 100644 --- a/packages/web-app-files/src/components/Trashbin.vue +++ b/packages/web-app-files/src/components/Trashbin.vue @@ -24,6 +24,7 @@ :resources="paginatedResources" :are-resources-clickable="false" :header-position="fileListHeaderY" + :hover="true" :sort-by="sortBy" :sort-dir="sortDir" @sort="handleSort" diff --git a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap index becb6f68123..ea3f14506bc 100644 --- a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap @@ -3,59 +3,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = `
-
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • @@ -66,59 +66,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = ` exports[`ContextActions menu items renders a list of actions for a folder 1`] = `
    -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • diff --git a/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap b/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap index 7987bf373aa..60f4ec09e9a 100644 --- a/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Trashbin component when the view is not loading anymore when length of the paginated resources is greater than zero should load the resource table with correct props 1`] = ` - +
    diff --git a/packages/web-app-files/tests/unit/views/__snapshots__/PublicFiles.spec.ts.snap b/packages/web-app-files/tests/unit/views/__snapshots__/PublicFiles.spec.ts.snap index 67b6465bc88..36651884f2e 100644 --- a/packages/web-app-files/tests/unit/views/__snapshots__/PublicFiles.spec.ts.snap +++ b/packages/web-app-files/tests/unit/views/__snapshots__/PublicFiles.spec.ts.snap @@ -1,3 +1,3 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`PublicFiles view when the view is not loading anymore when length of the paginated resources is greater than zero should load the resource table with the correct props 1`] = ``; +exports[`PublicFiles view when the view is not loading anymore when length of the paginated resources is greater than zero should load the resource table with the correct props 1`] = ``; diff --git a/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap b/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap index 7987bf373aa..60f4ec09e9a 100644 --- a/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap +++ b/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Trashbin component when the view is not loading anymore when length of the paginated resources is greater than zero should load the resource table with correct props 1`] = ` - +
    diff --git a/packages/web-app-files/tests/unit/views/shares/__snapshots__/SharedWithOthers.spec.js.snap b/packages/web-app-files/tests/unit/views/shares/__snapshots__/SharedWithOthers.spec.js.snap index 248c5880691..361053dfe19 100644 --- a/packages/web-app-files/tests/unit/views/shares/__snapshots__/SharedWithOthers.spec.js.snap +++ b/packages/web-app-files/tests/unit/views/shares/__snapshots__/SharedWithOthers.spec.js.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`SharedWithOthers when the wrapper is not loading anymore when length of paginated resources is greater than zero should load the resource table with correct props 1`] = ` - +
    - + @@ -31,7 +31,7 @@ exports[`Trashbin component when the view is not loading anymore when length of @@ -50,7 +50,7 @@ exports[`Trashbin component when the view is not loading anymore when length of @@ -69,7 +69,7 @@ exports[`Trashbin component when the view is not loading anymore when length of diff --git a/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap b/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap index 60f4ec09e9a..4655f395437 100644 --- a/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap +++ b/packages/web-app-files/tests/unit/views/__snapshots__/Trashbin.spec.js.snap @@ -7,7 +7,7 @@ exports[`Trashbin component when the view is not loading anymore when length of - + @@ -31,7 +31,7 @@ exports[`Trashbin component when the view is not loading anymore when length of @@ -50,7 +50,7 @@ exports[`Trashbin component when the view is not loading anymore when length of @@ -69,7 +69,7 @@ exports[`Trashbin component when the view is not loading anymore when length of diff --git a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Projects.spec.js.snap b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Projects.spec.js.snap index 41eb8264c80..d4431526d2a 100644 --- a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Projects.spec.js.snap +++ b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Projects.spec.js.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Spaces component should list spaces 1`] = ` -
    Store your project related files in Spaces for seamless collaboration.
    @@ -26,15 +26,15 @@ exports[`Spaces component should list spaces 1`] = `
    -
    -
    +
    +
      -
    • -
    diff --git a/packages/web-runtime/package.json b/packages/web-runtime/package.json index 3849372815f..4d3c1b5d92b 100644 --- a/packages/web-runtime/package.json +++ b/packages/web-runtime/package.json @@ -18,7 +18,7 @@ "luxon": "^2.3.0", "marked": "^4.0.12", "oidc-client": "1.11.5", - "owncloud-design-system": "^13.0.0-rc.3", + "owncloud-design-system": "^13.0.0-rc.4", "owncloud-sdk": "~3.0.0-alpha.1", "p-queue": "^6.1.1", "popper-max-size-modifier": "^0.2.0", diff --git a/packages/web-runtime/tests/unit/components/SidebarNav/__snapshots__/SidebarNav.spec.js.snap b/packages/web-runtime/tests/unit/components/SidebarNav/__snapshots__/SidebarNav.spec.js.snap index 06815ba152d..1c7d2242891 100644 --- a/packages/web-runtime/tests/unit/components/SidebarNav/__snapshots__/SidebarNav.spec.js.snap +++ b/packages/web-runtime/tests/unit/components/SidebarNav/__snapshots__/SidebarNav.spec.js.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`OcSidebarNav renders navItems into a list 1`] = ` -
    From 3134859b3f326c7781811d24ee6118f181fd7d80 Mon Sep 17 00:00:00 2001 From: Pascal Wengerter Date: Thu, 17 Mar 2022 11:56:21 +0100 Subject: [PATCH 07/15] Bump ODS to v13.0.0-rc.4 --- changelog/unreleased/enhancement-update-ods | 8 +-- .../__snapshots__/ContextActions.spec.js.snap | 52 +++++++++---------- .../RecipientContainer.spec.js.snap | 12 ++--- .../__snapshots__/Trashbin.spec.js.snap | 8 +-- .../views/__snapshots__/Trashbin.spec.js.snap | 8 +-- .../__snapshots__/Projects.spec.js.snap | 10 ++-- packages/web-runtime/package.json | 2 +- .../__snapshots__/SidebarNav.spec.js.snap | 6 +-- .../__snapshots__/SidebarNavItem.spec.js.snap | 4 +- .../__snapshots__/FeedbackLink.spec.js.snap | 2 +- .../__snapshots__/ThemeSwitcher.spec.js.snap | 12 ++--- yarn.lock | 10 ++-- 12 files changed, 68 insertions(+), 66 deletions(-) diff --git a/changelog/unreleased/enhancement-update-ods b/changelog/unreleased/enhancement-update-ods index 26258d7e8b5..3c54b1c75db 100644 --- a/changelog/unreleased/enhancement-update-ods +++ b/changelog/unreleased/enhancement-update-ods @@ -1,15 +1,17 @@ -Enhancement: Update ODS to v13.0.0-rc.3 +Enhancement: Update ODS to v13.0.0-rc.4 -We updated the ownCloud Design System to version 13.0.0-rc.3. Please refer to the full changelog in the ODS release (linked) for more details. Summary: +We updated the ownCloud Design System to version 13.0.0-rc.4. Please refer to the full changelog in the ODS release (linked) for more details. Summary: - Change - Default type of OcButton: https//github.com/owncloud/owncloud-design-system/pull/2009 - Change - Remove OcStatusIndicators from OcResource: https://github.com/owncloud/owncloud-design-system/pull/2014 - Enhancement - Redesign OcStatusIndicators: https://github.com/owncloud/owncloud-design-system/pull/2014 - Enhancement - Icons for drawio, ifc and odg resource types: https//github.com/owncloud/owncloud-design-system/pull/2005 - Enhancement - Apply size property to oc-tag: https//github.com/owncloud/owncloud-design-system/pull/2011 +- Enhancement - Underline OcResourceName: https//github.com/owncloud/owncloud-design-system/pull/2019 - Bugfix - Disabled OcSelect background: https//github.com/owncloud/owncloud-design-system/pull/2008 - Bugfix - Icons/Thumbnails were only visible for clickable resources: https//github.com/owncloud/owncloud-design-system/pull/2007 https://github.com/owncloud/web/pull/6540 https://github.com/owncloud/web/pull/6600 -https://github.com/owncloud/owncloud-design-system/releases/tag/v13.0.0-rc.3 +https://github.com/owncloud/web/pull/6584 +https://github.com/owncloud/owncloud-design-system/releases/tag/v13.0.0-rc.4 diff --git a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap index ea3f14506bc..9849b9e62b2 100644 --- a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ContextActions.spec.js.snap @@ -3,59 +3,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = `
    -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • @@ -66,59 +66,59 @@ exports[`ContextActions menu items renders a list of actions for a file 1`] = ` exports[`ContextActions menu items renders a list of actions for a folder 1`] = `
    -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • -
  • diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/InviteCollaborator/__snapshots__/RecipientContainer.spec.js.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/InviteCollaborator/__snapshots__/RecipientContainer.spec.js.snap index efc1218935b..6b5ee61735a 100644 --- a/packages/web-app-files/tests/unit/components/SideBar/Shares/InviteCollaborator/__snapshots__/RecipientContainer.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/InviteCollaborator/__snapshots__/RecipientContainer.spec.js.snap @@ -2,17 +2,17 @@ exports[`InviteCollaborator RecipientContainer displays an avatar image if capability is present 1`] = ` -

    Albert Einstein

    `; -exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 1`] = `

    Albert Einstein

    `; +exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 1`] = `

    Albert Einstein

    `; -exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 2`] = `

    physics-lovers

    `; +exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 2`] = `

    physics-lovers

    `; -exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 3`] = `

    guest-user

    `; +exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 3`] = `

    guest-user

    `; -exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 4`] = `

    remote-user

    `; +exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 4`] = `

    remote-user

    `; -exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 5`] = `

    Albert Einstein

    `; +exports[`InviteCollaborator RecipientContainer renders a recipient with a deselect button different recipients for different shareTypes 5`] = `

    Albert Einstein

    `; diff --git a/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap b/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap index 60f4ec09e9a..4655f395437 100644 --- a/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap +++ b/packages/web-app-files/tests/unit/components/__snapshots__/Trashbin.spec.js.snap @@ -7,7 +7,7 @@ exports[`Trashbin component when the view is not loading anymore when length of
    Name Name Status -
    +
    -
    +
    -
    +
    Name Name Status -
    +
    -
    +
    -
    +