From 0cea6e9fa1872cc0175635113085f25808093a60 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Sat, 5 Oct 2024 16:16:29 +0000
Subject: [PATCH] refactor(transformer): exponentiation transform: reduce
 identifier cloning (#6297)

We already have to look up the reference, so use the `SymbolId` from that reference, rather than looking it up again in `clone_identifier_reference`.
---
 .../src/es2016/exponentiation_operator.rs     | 22 +++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/crates/oxc_transformer/src/es2016/exponentiation_operator.rs b/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
index d488d5e65e3bd..fc3f3d6fa9495 100644
--- a/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
+++ b/crates/oxc_transformer/src/es2016/exponentiation_operator.rs
@@ -208,22 +208,26 @@ impl<'a, 'ctx> ExponentiationOperator<'a, 'ctx> {
     ) -> Option<Expression<'a>> {
         let reference = match node {
             SimpleAssignmentTarget::AssignmentTargetIdentifier(ident) => {
-                if ident
-                    .reference_id
-                    .get()
-                    .is_some_and(|reference_id| ctx.symbols().has_binding(reference_id))
-                {
+                let reference = ctx.symbols().get_reference(ident.reference_id().unwrap());
+                if let Some(symbol_id) = reference.symbol_id() {
                     // this variable is declared in scope so we can be 100% sure
                     // that evaluating it multiple times won't trigger a getter
                     // or something else
                     return Some(ctx.ast.expression_from_identifier_reference(
-                        ctx.clone_identifier_reference(ident, ReferenceFlags::Write),
+                        ctx.create_bound_reference_id(
+                            SPAN,
+                            ident.name.clone(),
+                            symbol_id,
+                            ReferenceFlags::Write,
+                        ),
                     ));
                 }
                 // could possibly trigger a getter so we need to only evaluate it once
-                ctx.ast.expression_from_identifier_reference(
-                    ctx.clone_identifier_reference(ident, ReferenceFlags::Read),
-                )
+                ctx.ast.expression_from_identifier_reference(ctx.create_unbound_reference_id(
+                    SPAN,
+                    ident.name.clone(),
+                    ReferenceFlags::Read,
+                ))
             }
             match_member_expression!(SimpleAssignmentTarget) => {
                 let expr = match node {