Skip to content

Commit 8c09592

Browse files
committed
test(napi/parser): align fixture version with other tasks (#14146)
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
1 parent c0c0c17 commit 8c09592

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

napi/parser/bench.bench.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ let fixtureUrls = [
1919
'https://cdn.jsdelivr.net/gh/oxc-project/benchmark-files@main/cal.com.tsx',
2020
'https://cdn.jsdelivr.net/gh/oxc-project/benchmark-files@main/RadixUIAdoptionSection.jsx',
2121
'https://cdn.jsdelivr.net/npm/pdfjs-dist@4.0.269/build/pdf.mjs',
22-
'https://cdn.jsdelivr.net/npm/antd@5.12.5/dist/antd.js',
22+
'https://cdn.jsdelivr.net/npm/antd@4.16.1/dist/antd.js',
2323
];
2424

2525
// For sharding in CI - specify single fixture to run benchmarks on

napi/parser/test/parse-raw.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ const benchFixtureUrls = [
6666
// Heavy with classes (554K)
6767
'https://cdn.jsdelivr.net/npm/pdfjs-dist@4.0.269/build/pdf.mjs',
6868
// ES5 (3.9M)
69-
'https://cdn.jsdelivr.net/npm/antd@5.12.5/dist/antd.js',
69+
'https://cdn.jsdelivr.net/npm/antd@4.16.1/dist/antd.js',
7070
];
7171

7272
await mkdir(TARGET_DIR_PATH, { recursive: true });

0 commit comments

Comments
 (0)