perf(linter): run next/no-duplicate-head on nodes instead of symbols

camchenry · camchenry · commit b93e2d56ff8a · 2025-10-14T22:16:32.000-04:00
diff --git a/crates/oxc_linter/src/generated/rule_runner_impls.rs b/crates/oxc_linter/src/generated/rule_runner_impls.rs
@@ -1714,8 +1714,9 @@ impl RuleRunner for crate::rules::nextjs::no_document_import_in_page::NoDocument
 }
 
 impl RuleRunner for crate::rules::nextjs::no_duplicate_head::NoDuplicateHead {
-    const NODE_TYPES: Option<&AstTypesBitset> = None;
-    const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnSymbol;
+    const NODE_TYPES: Option<&AstTypesBitset> =
+        Some(&AstTypesBitset::from_types(&[AstType::ImportDeclaration]));
+    const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
 }
 
 impl RuleRunner for crate::rules::nextjs::no_head_element::NoHeadElement {
diff --git a/crates/oxc_linter/src/rules/nextjs/no_duplicate_head.rs b/crates/oxc_linter/src/rules/nextjs/no_duplicate_head.rs
@@ -1,6 +1,7 @@
 use oxc_ast::AstKind;
 use oxc_diagnostics::{LabeledSpan, OxcDiagnostic};
 use oxc_macros::declare_oxc_lint;
+use oxc_semantic::AstNode;
 use oxc_span::GetSpan;
 
 use crate::{context::LintContext, rule::Rule};
@@ -72,20 +73,27 @@ declare_oxc_lint!(
 );
 
 impl Rule for NoDuplicateHead {
-    fn run_on_symbol(&self, symbol_id: oxc_semantic::SymbolId, ctx: &LintContext<'_>) {
-        let symbols = ctx.scoping();
-        let name = symbols.symbol_name(symbol_id);
-        if name != "Head" {
+    fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
+        let AstKind::ImportDeclaration(import_decl) = node.kind() else {
             return;
-        }
+        };
+        let Some(specifiers) = &import_decl.specifiers else {
+            return;
+        };
+        let Some(head_specifier) = specifiers.iter().find(|s| s.name() == "Head") else {
+            return;
+        };
+
+        let scoping = ctx.scoping();
+        let symbol_id = head_specifier.local().symbol_id();
 
-        let flags = symbols.symbol_flags(symbol_id);
+        let flags = scoping.symbol_flags(symbol_id);
         if !flags.is_import() {
             return;
         }
 
-        let scope_id = symbols.symbol_scope_id(symbol_id);
-        if scope_id != ctx.scoping().root_scope_id() {
+        let scope_id = scoping.symbol_scope_id(symbol_id);
+        if scope_id != scoping.root_scope_id() {
             return;
         }
 
@@ -100,7 +108,7 @@ impl Rule for NoDuplicateHead {
             LabeledSpan::underline(span)
         };
 
-        for reference in symbols.get_resolved_references(symbol_id) {
+        for reference in scoping.get_resolved_references(symbol_id) {
             if !reference.is_read() {
                 continue;
             }
@@ -125,11 +133,9 @@ impl Rule for NoDuplicateHead {
         }
 
         // `labels` is empty if 0 or 1 `<Head>` found
-        if labels.is_empty() {
-            return;
+        if !labels.is_empty() {
+            ctx.diagnostic(no_duplicate_head(labels));
         }
-
-        ctx.diagnostic(no_duplicate_head(labels));
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1714,8 +1714,9 @@ impl RuleRunner for crate::rules::nextjs::no_document_import_in_page::NoDocument`
`1714`	`1714`	`}`
`1715`	`1715`
`1716`	`1716`	`impl RuleRunner for crate::rules::nextjs::no_duplicate_head::NoDuplicateHead {`
`1717`		`- const NODE_TYPES: Option<&AstTypesBitset> = None;`
`1718`		`- const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnSymbol;`
	`1717`	`+ const NODE_TYPES: Option<&AstTypesBitset> =`
	`1718`	`+ Some(&AstTypesBitset::from_types(&[AstType::ImportDeclaration]));`
	`1719`	`+ const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;`
`1719`	`1720`	`}`
`1720`	`1721`
`1721`	`1722`	`impl RuleRunner for crate::rules::nextjs::no_head_element::NoHeadElement {`