fix(linter): fix jsx-a11y/label-has-associated-control default values (#11832)

`LabelHasAssociatedControl.from_configuration` never got called.
Only the `LabelHasAssociatedControlConfig::default()`.

closes #11644

Author: Sysix

apps/oxlint/fixtures/issue_11644/.oxlintrc.json

@@ -0,0 +1,26 @@
+{
+  "plugins": [
+    "eslint",
+    "import",
+    "jsx-a11y",
+    "nextjs",
+    "node",
+    "oxc",
+    "promise",
+    "react",
+    "react-perf",
+    "typescript",
+    "unicorn"
+  ],
+  "rules": {
+    "import/no-default-export": 0,
+    "no-console": 1,
+    "react/button-has-type": 0,
+    "react/rules-of-hooks": 2,
+    "typescript/explicit-function-return-type": 0,
+    "typescript/no-non-null-assertion": 0,
+    "unicorn/filename-case": [2, { "case": "kebabCase" }],
+    "unicorn/no-nested-ternary": 0,
+    // "jsx-a11y/label-has-associated-control": ["warn", { "depth": 0}]
+  }
+}

apps/oxlint/fixtures/issue_11644/test.jsx

@@ -0,0 +1,18 @@
+// oxlint-disable-next-line no-unused-vars
+function Foo() {
+  return (
+    <template>
+      <label>
+        <span>name</span>
+        <input
+          defaultValue={
+            actionState.payload?.get("name")?.toString() ?? "Pool party"
+          }
+          name="name"
+          placeholder="name"
+          type="text"
+        />
+      </label>
+    </template>
+  )
+}

apps/oxlint/src/lint.rs

@@ -1159,4 +1159,10 @@ mod test {
         let args = &["-c", ".oxlintrc.json"];
         Tester::new().with_cwd("fixtures/issue_10394".into()).test_and_snapshot(args);
     }
+
+    #[test]
+    fn test_jsx_a11y_label_has_associated_control() {
+        let args = &["-c", ".oxlintrc.json"];
+        Tester::new().with_cwd("fixtures/issue_11644".into()).test_and_snapshot(args);
+    }
 }

apps/oxlint/src/snapshots/fixtures__issue_11644_-c .oxlintrc.json@oxlint.snap

@@ -0,0 +1,12 @@
+---
+source: apps/oxlint/src/tester.rs
+---
+########## 
+arguments: -c .oxlintrc.json
+working directory: fixtures/issue_11644
+----------
+Found 0 warnings and 0 errors.
+Finished in <variable>ms on 1 file with 158 rules using 1 threads.
+----------
+CLI result: LintSucceeded
+----------

crates/oxc_linter/src/rules/jsx_a11y/label_has_associated_control.rs

@@ -58,12 +58,20 @@ impl Deref for LabelHasAssociatedControl {
 
 impl Default for LabelHasAssociatedControlConfig {
     fn default() -> Self {
+        let mut control_builder = GlobSetBuilder::new();
+        control_builder.add(Glob::new("input").unwrap());
+        control_builder.add(Glob::new("meter").unwrap());
+        control_builder.add(Glob::new("output").unwrap());
+        control_builder.add(Glob::new("progress").unwrap());
+        control_builder.add(Glob::new("select").unwrap());
+        control_builder.add(Glob::new("textarea").unwrap());
+
         Self {
             depth: 2,
             assert: Assert::Either,
             label_components: vec!["label".into()],
             label_attributes: vec!["alt".into(), "aria-label".into(), "aria-labelledby".into()],
-            control_components: GlobSet::empty(),
+            control_components: control_builder.build().unwrap(),
         }
     }
 }
@@ -114,16 +122,7 @@ impl Rule for LabelHasAssociatedControl {
     fn from_configuration(value: serde_json::Value) -> Self {
         let mut config = LabelHasAssociatedControlConfig::default();
 
-        let mut control_builder = GlobSetBuilder::new();
-        control_builder.add(Glob::new("input").unwrap());
-        control_builder.add(Glob::new("meter").unwrap());
-        control_builder.add(Glob::new("output").unwrap());
-        control_builder.add(Glob::new("progress").unwrap());
-        control_builder.add(Glob::new("select").unwrap());
-        control_builder.add(Glob::new("textarea").unwrap());
-
         let Some(options) = value.get(0) else {
-            config.control_components = control_builder.build().unwrap();
             return Self(Box::new(config));
         };
 
@@ -166,6 +165,14 @@ impl Rule for LabelHasAssociatedControl {
             }
         }
 
+        let mut control_builder = GlobSetBuilder::new();
+        control_builder.add(Glob::new("input").unwrap());
+        control_builder.add(Glob::new("meter").unwrap());
+        control_builder.add(Glob::new("output").unwrap());
+        control_builder.add(Glob::new("progress").unwrap());
+        control_builder.add(Glob::new("select").unwrap());
+        control_builder.add(Glob::new("textarea").unwrap());
+
         if let Some(control_components) =
             options.get("controlComponents").and_then(serde_json::Value::as_array)
         {
@@ -185,13 +192,6 @@ impl Rule for LabelHasAssociatedControl {
         config.control_components = if let Ok(controls) = control_builder.build() {
             controls
         } else {
-            let mut control_builder = GlobSetBuilder::new();
-            control_builder.add(Glob::new("input").unwrap());
-            control_builder.add(Glob::new("meter").unwrap());
-            control_builder.add(Glob::new("output").unwrap());
-            control_builder.add(Glob::new("progress").unwrap());
-            control_builder.add(Glob::new("select").unwrap());
-            control_builder.add(Glob::new("textarea").unwrap());
             control_builder.build().unwrap()
         };
 
@@ -918,6 +918,22 @@ fn test() {
         ),
         // Issue: <https://github.com/oxc-project/oxc/issues/7849>
         ("<FilesContext.Provider value={{ addAlert, cwdInfo }} />", None, None),
+        // Issue: <https://github.com/oxc-project/oxc/issues/11644>
+        (
+            r#"<label>
+                <span>name</span>
+                <input
+                    defaultValue={
+                    actionState.payload?.get("name")?.toString() ?? "Pool party"
+                    }
+                    name="name"
+                    placeholder="name"
+                    type="text"
+                />
+               </label>"#,
+            None,
+            None,
+        ),
     ];
 
     let fail = vec![