Skip to content

Commit fcfd3e7

Browse files
committed
chore(linter): disable linting .d.ts files for now
1 parent 21e8f0a commit fcfd3e7

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

crates/oxc_linter/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ impl Linter {
133133
let should_run_on_jest_node =
134134
ctx_host.plugins().has_test() && ctx_host.frameworks().is_test();
135135

136-
if path.ends_with(".d.ts") {
136+
if path.to_str().is_some_and(|str| str.ends_with(".d.ts")) {
137137
return ctx_host.take_diagnostics();
138138
}
139139

crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,7 +1094,7 @@ fn test() {
10941094
),
10951095
];
10961096

1097-
let dts_pass = vec![
1097+
let _dts_pass: Vec<(&'static str, Option<serde_json::Value>, Option<serde_json::Value>)> = vec![
10981098
(
10991099
"
11001100
/** @default 0 */
@@ -1158,18 +1158,20 @@ fn test() {
11581158
None,
11591159
),
11601160
];
1161-
let dts_fail = vec![(
1162-
"
1161+
let _dts_fail: Vec<(&'static str, Option<serde_json::Value>, Option<serde_json::Value>)> =
1162+
vec![(
1163+
"
11631164
/** @typoo {string} (fail: invalid name) */
11641165
let a;
11651166
",
1166-
None,
1167-
None,
1168-
)];
1167+
None,
1168+
None,
1169+
)];
11691170

11701171
Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, pass, fail).test_and_snapshot();
1172+
// TODO: re-enable here when we officially support linting `.d.ts` files
11711173
// Currently only 1 snapshot can be saved under a rule name
1172-
Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, dts_pass, dts_fail)
1173-
.change_rule_path("test.d.ts")
1174-
.test();
1174+
// Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, dts_pass, dts_fail)
1175+
// .change_rule_path("test.d.ts")
1176+
// .test();
11751177
}

0 commit comments

Comments
 (0)