Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Apr 14, 2025

closes #10396

  • Fix the false positive in typescript
  • Align with eslint -- set the default value of builtinGlobals to true

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 14, 2025
@shulaoda shulaoda marked this pull request as draft April 14, 2025 17:30
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2025

CodSpeed Instrumentation Performance Report

Merging #10402 will not alter performance

Comparing 04-15-fix/false-positive-in-eslint-no-redeclare (72d5074) with main (5d1dfb5)

Summary

✅ 36 untouched benchmarks

@shulaoda shulaoda requested review from Sysix, camc314 and camchenry April 14, 2025 17:47
@shulaoda shulaoda marked this pull request as ready for review April 14, 2025 17:48
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
Copy link
Member

camchenry commented Apr 14, 2025

Merge activity

closes #10396

- Fix the false positive in `typescript`
- Align with `eslint` -- set the default value of `builtinGlobals` to `true`
@graphite-app graphite-app bot force-pushed the 04-15-fix/false-positive-in-eslint-no-redeclare branch from f4895e5 to 72d5074 Compare April 14, 2025 18:23
@graphite-app graphite-app bot merged commit 72d5074 into main Apr 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 04-15-fix/false-positive-in-eslint-no-redeclare branch April 14, 2025 18:27
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: no-redeclare triggers for function overloads

3 participants