perf(transformer/class-properties): return early if no private fields are found #10418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Instrumentation Performance ReportMerging #10418 will improve performances by 6.34%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
04-15-perf_transformer_class-properties_return_early_if_no_private_fields_are_found
branch
from
caa8ebb to
2351230
Compare
This was referenced Apr 15, 2025
Closed
Dunqing
force-pushed
the
04-15-perf_transformer_class-properties_return_early_if_no_private_fields_are_found
branch
from
2351230 to
f431eec
Compare
Member
Merge activity
|
… are found (#10418) If a class or its parent classes don't have a private field, we don't need to transform the expression. Because we only transform expressions that include a private field.
graphite-app
bot
force-pushed
the
04-15-perf_transformer_class-properties_return_early_if_no_private_fields_are_found
branch
from
f431eec to
1457e68
Compare
Dunqing
deleted the
04-15-perf_transformer_class-properties_return_early_if_no_private_fields_are_found
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
…mments (#10447) Follow-on after #10418. Pure refactor. `private_field_count` is accessed in both the entry and exit phases of the transform, so move that field up to be with the other fields which are in that same category. Expand the comment which explains how this optimization works. Also, when reviewing #10418, I had to trace through the logic to make sure that it wasn't possible for decreasing `private_field_count` on exit to get skipped if `is_transform_required` is `false`. Turns out it's not a problem - `is_transform_required` is always `true` if class has any private properties/methods. Add comments to clarify that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a class or its parent classes don't have a private field, we don't need to transform the expression. Because we only transform expressions that include a private field.