perf(linter): replace phf_set with array in utils/vitest
#10427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Instrumentation Performance ReportMerging #10427 will not alter performanceComparing Summary
|
Member
Merge activity
|
Related to #10076 Benchmark repo: https://github.com/shulaoda/rust-benchmark-test Benchmark result: https://codspeed.io/shulaoda/rust-benchmark-test/benchmarks BTW, the `VALID_VITEST_FN_CALL_CHAINS` is really huge. I plan to try optimizing it when I have some time later.
graphite-app
bot
force-pushed
the
04-16-perf/replace-phf_set-with-array-in-utils/vitest
branch
from
06fdc95 to
c0f0369
Compare
graphite-app
bot
deleted the
04-16-perf/replace-phf_set-with-array-in-utils/vitest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10076
Benchmark repo: https://github.com/shulaoda/rust-benchmark-test
Benchmark result: https://codspeed.io/shulaoda/rust-benchmark-test/benchmarks
BTW, the
VALID_VITEST_FN_CALL_CHAINSis really huge. I plan to try optimizing it when I have some time later.