fix(parser): adjust class start position when decorators are involved #10438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10438 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
04-16-fix_parser_adjust_class_start_position_when_decorators_are_involved
branch
from
1b8b64d to
39540f7
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
04-16-fix_parser_adjust_class_start_position_when_decorators_are_involved
branch
from
39540f7 to
58ab8ff
Compare
graphite-app
bot
deleted the
04-16-fix_parser_adjust_class_start_position_when_decorators_are_involved
branch
This was referenced Apr 16, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
…irst statement is `@dec export class C {}` (#10448)
#10438 aligned the spans of `@dec export class C {}` and `@dec export default class {}` with TS-ESLint.
```ts
@dec export class C {}
^^^^^^^^^^^^^^^^^ ExportNamedDeclaration
^^^^^^^^^^ Class
^^^^ Decorator
@dec export default class {}
^^^^^^^^^^^^^^^^^^^^^^^ ExportDefaultDeclaration
^^^^^^^^ Class
^^^^ Decorator
```
However, this causes a problem where one of these is the first statement in the file. In TS-ESTree, `Program` start is the start of the first token (excluding whitespace and comments). So we need to set `Program` start to the start of the decorator in these cases.
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
#10449) #10438 altered span of `Class` so it starts later in the case of `@dec export class C {}` and `@dec export default class {}`. Update `Utf8ToUtf16Converter` to handle this odd case, and visit decorators before the `export` keyword before processing the span start of `ExportNamedDeclaration` / `ExportDefaultDeclaration`, so that span offsets are still processed in ascending order.
This was referenced Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10409