fix(oxc_linter): Make linter file paths clickable within JetBrains terminals #11619
Conversation
CodSpeed Instrumentation Performance ReportMerging #11619 will not alter performanceComparing Summary
|
|
@camc314 this isn't very high priority, but it would be a pretty good improvement for JetBrains IDEs if it was resolved. Gave it my best attempt, but I don't know very much Rust. |
There was a problem hiding this comment.
@camc314 this isn't very high priority, but it would be a pretty good improvement for JetBrains IDEs if it was resolved. Gave it my best attempt, but I don't know very much Rust.
thank you for working on this, this is great!
I pushed a new commit removing the url dependency, and the output appears to be the same?
do you mind testing this and letting me know if it still looks ok?
|
I should be able to test later this morning and let you know. |
On macOS the tests still fail when running through a JetBrains terminal. The tests pass through a regular macOS terminal. The output from the CLI looks fine when running through a JetBrains terminal. |
|
I don't have a Windows device to test on until a release is made, but the macOS changes still look fine to me. |
…rminals JetBrains terminals don't work reliably with relative paths to hyperlink to the file. Outputting the full file URL instead works consistently.
3 participants
JetBrains terminals don't work reliably with relative paths to hyperlink to the file. Outputting the full file URL instead works consistently.
Fixes #8444.
This seems to work, but there is some cleanup that probably needs to be done by somebody more experienced. Left some inline comments for this.
Current
With this change in a JetBrains terminal (IntelliJ in this case)
With this change in a regular macOS terminal
