Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 16, 2025

There were no tests covering escaping backslashes in JSON. Add some.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jun 16, 2025
Copy link
Member Author

overlookmotel commented Jun 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 16, 2025

CodSpeed Instrumentation Performance Report

Merging #11756 will improve performances by 15.26%

Comparing 06-16-test_ast_estree_more_tests_for_escaping_strings_in_json (c53a7bd) with 06-16-perf_ast_estree_faster_serializing_strings_to_json (c4faee2)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.26%

@overlookmotel overlookmotel marked this pull request as ready for review June 16, 2025 19:24
@overlookmotel overlookmotel force-pushed the 06-16-perf_ast_estree_faster_serializing_strings_to_json branch from 1ebaf29 to f953447 Compare June 16, 2025 21:44
@overlookmotel overlookmotel force-pushed the 06-16-test_ast_estree_more_tests_for_escaping_strings_in_json branch from 842c5f5 to 784cab9 Compare June 16, 2025 21:44
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
Copy link
Member

Boshen commented Jun 17, 2025

Merge activity

There were no tests covering escaping backslashes in JSON. Add some.
@graphite-app graphite-app bot force-pushed the 06-16-perf_ast_estree_faster_serializing_strings_to_json branch from f953447 to c4faee2 Compare June 17, 2025 02:07
@graphite-app graphite-app bot force-pushed the 06-16-test_ast_estree_more_tests_for_escaping_strings_in_json branch from 784cab9 to c53a7bd Compare June 17, 2025 02:08
Base automatically changed from 06-16-perf_ast_estree_faster_serializing_strings_to_json to main June 17, 2025 02:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
@graphite-app graphite-app bot merged commit c53a7bd into main Jun 17, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 06-16-test_ast_estree_more_tests_for_escaping_strings_in_json branch June 17, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants