Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jun 20, 2025

LabelHasAssociatedControl.from_configuration never got called.
Only the LabelHasAssociatedControlConfig::default().

closes #11644

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Jun 20, 2025
Copy link
Member Author

Sysix commented Jun 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review June 20, 2025 12:55
@Sysix Sysix requested a review from camc314 as a code owner June 20, 2025 12:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed Instrumentation Performance Report

Merging #11832 will not alter performance

Comparing 06-20-fix_linter_fix_jsx-a11y_label-has-associated-control_default_values (d991fed) with main (a0a4aa1)

Summary

✅ 17 untouched benchmarks
⁉️ 21 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ codegen[RadixUIAdoptionSection.jsx] 132.1 µs N/A N/A
⁉️ codegen[binder.ts] 4.8 ms N/A N/A
⁉️ codegen[cal.com.tsx] 38.9 ms N/A N/A
⁉️ codegen[react.development.js] 2.2 ms N/A N/A
⁉️ linter[RadixUIAdoptionSection.jsx] 2.6 ms N/A N/A
⁉️ linter[binder.ts] 149.9 ms N/A N/A
⁉️ linter[cal.com.tsx] 1.2 s N/A N/A
⁉️ linter[react.development.js] 54.9 ms N/A N/A
⁉️ mangler[RadixUIAdoptionSection.jsx] 14.3 µs N/A N/A
⁉️ mangler[binder.ts] 808.6 µs N/A N/A
⁉️ mangler[cal.com.tsx] 3.1 ms N/A N/A
⁉️ mangler[react.development.js] 284.4 µs N/A N/A
⁉️ minifier[RadixUIAdoptionSection.jsx] 66.2 µs N/A N/A
⁉️ minifier[binder.ts] 3.4 ms N/A N/A
⁉️ minifier[cal.com.tsx] 23 ms N/A N/A
⁉️ minifier[react.development.js] 1.8 ms N/A N/A
⁉️ isolated-declarations[vue-id.ts] 57.5 ms N/A N/A
⁉️ transformer[RadixUIAdoptionSection.jsx] 128.5 µs N/A N/A
⁉️ transformer[binder.ts] 1.4 ms N/A N/A
⁉️ transformer[cal.com.tsx] 24.6 ms N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Sysix Sysix changed the title fix(linter): fix jsx-a11y/label-has-associated-control) default values fix(linter): fix jsx-a11y/label-has-associated-control default values Jun 22, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 23, 2025
Copy link
Contributor

camc314 commented Jun 23, 2025

Merge activity

…es (#11832)

`LabelHasAssociatedControl.from_configuration` never got called.
Only the `LabelHasAssociatedControlConfig::default()`.

closes #11644
@graphite-app graphite-app bot force-pushed the 06-20-fix_linter_fix_jsx-a11y_label-has-associated-control_default_values branch from 072d17c to d991fed Compare June 23, 2025 08:56
@graphite-app graphite-app bot merged commit d991fed into main Jun 23, 2025
18 of 24 checks passed
@graphite-app graphite-app bot deleted the 06-20-fix_linter_fix_jsx-a11y_label-has-associated-control_default_values branch June 23, 2025 09:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint-plugin-jsx-a11y(label-has-associated-control)

3 participants