Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jun 20, 2025

closes #11594

I think this is a bug too :). The own export entries should be counted into the threshold

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jun 20, 2025
Copy link
Member Author

Sysix commented Jun 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix changed the title fix(linter): count own indirect export entries to the threshould for oxc/no-barrel-file fix(linter): count own indirect export entries to the threshold for oxc/no-barrel-file Jun 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed Instrumentation Performance Report

Merging #11838 will degrade performances by 13.74%

Comparing 06-20-fix_linter_count_own_indirect_export_entries_to_the_threshould_for_oxc_no-barrel-file_ (a0a4aa1) with main (fe79965)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.74%

@Sysix Sysix marked this pull request as ready for review June 20, 2025 18:29
@Sysix Sysix requested a review from camc314 as a code owner June 20, 2025 18:29
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 23, 2025
Copy link
Contributor

camc314 commented Jun 23, 2025

Merge activity

…oxc/no-barrel-file` (#11838)

closes #11594

I think this is a bug too :). The own export entries should be counted into the threshold
@graphite-app graphite-app bot force-pushed the 06-20-fix_linter_count_own_indirect_export_entries_to_the_threshould_for_oxc_no-barrel-file_ branch from 6eab134 to a0a4aa1 Compare June 23, 2025 08:43
@graphite-app graphite-app bot merged commit a0a4aa1 into main Jun 23, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 23, 2025
@graphite-app graphite-app bot deleted the 06-20-fix_linter_count_own_indirect_export_entries_to_the_threshould_for_oxc_no-barrel-file_ branch June 23, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: false negative in oxc/no-barrel-file

3 participants