Skip to content

fix(linter): count own indirect export entries to the threshold for oxc/no-barrel-file #11838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(linter): count own indirect export entries to the threshold for oxc/no-barrel-file #11838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/oxc_linter/src/rules/oxc/no_barrel_file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ impl Rule for NoBarrelFile {
let mut total: usize = 0;

for module_request in module_requests {
// the own module is counted as well
total += 1;

if let Some(remote_module) =
module_record.loaded_modules.read().unwrap().get(module_request.name())
{
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/snapshots/oxc_no_barrel_file.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
source: crates/oxc_linter/src/tester.rs
---
⚠ oxc(no-barrel-file): Barrel file detected, 6 modules are loaded.
⚠ oxc(no-barrel-file): Barrel file detected, 10 modules are loaded.
╭─[index.ts:1:15]
1 │ export * from "./deep/a.js";
· ──────┬──────
Expand All @@ -14,6 +14,6 @@ source: crates/oxc_linter/src/tester.rs
· ╰── 1 modules
4 │ export * from "./deep/d.js";
╰────
help: Loading 6 modules is slow for runtimes and bundlers.
help: Loading 10 modules is slow for runtimes and bundlers.
The configured threshold is 1.
See also: <https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7>.
Loading