-
-
Notifications
You must be signed in to change notification settings - Fork 720
fix(ast): MemberExpression::static_property_info use cooked not raw for TemplateElements
#11879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ast): MemberExpression::static_property_info use cooked not raw for TemplateElements
#11879
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11879 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Merge activity
|
3e1d6cf to
168f776
Compare
25ee137 to
fe78dcf
Compare
Instead of iterating over `allow` and recalculating the static property name on each turn of the loop, check if the property name is allowed once it's already calculated with `MemberExpression::static_property_info`. This PR also ensures that the fix made in #11879 works. If not stacked on top of that PR, one of the tests added in #11878 fails.

Same as #11829.
MemberExpression::static_property_infousecookednotrawforTemplateElements.The value of a template literal is the cooked version. e.g.
obj[`\x41`]-> property name"A"not"\x41".