perf(linter/no-console): get static property name only once #11880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
This was referenced Jun 24, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11880 will not alter performanceComparing Summary
|
camc314
approved these changes
Jun 24, 2025
Contributor
Merge activity
|
Instead of iterating over `allow` and recalculating the static property name on each turn of the loop, check if the property name is allowed once it's already calculated with `MemberExpression::static_property_info`. This PR also ensures that the fix made in #11879 works. If not stacked on top of that PR, one of the tests added in #11878 fails.
graphite-app
bot
force-pushed
the
06-24-fix_ast_memberexpression_static_property_info_use_cooked_not_raw_for_templateelement_s
branch
from
25ee137 to
fe78dcf
Compare
graphite-app
bot
force-pushed
the
06-24-perf_linter_no-console_get_static_property_name_only_once
branch
from
942808a to
66dbf9d
Compare
Base automatically changed from
06-24-fix_ast_memberexpression_static_property_info_use_cooked_not_raw_for_templateelement_s
to
main
June 24, 2025 13:42
graphite-app
bot
deleted the
06-24-perf_linter_no-console_get_static_property_name_only_once
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of iterating over
allowand recalculating the static property name on each turn of the loop, check if the property name is allowed once it's already calculated withMemberExpression::static_property_info.This PR also ensures that the fix made in #11879 works. If not stacked on top of that PR, one of the tests added in #11878 fails.