perf(ast): remove redundant checks from MemberExpression::static_property_info and ComputedMemberExpression::static_property_name
#11882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
CodSpeed Instrumentation Performance ReportMerging #11882 will degrade performances by 12.72%Comparing Summary
Benchmarks breakdown
|
camchenry
approved these changes
Jun 24, 2025
graphite-app
bot
changed the base branch from
06-24-perf_linter_no-console_get_static_property_name_only_once
to
graphite-base/11882
graphite-app
bot
force-pushed
the
06-24-perf_ast_remove_redundant_checks_from_memberexpression_static_property_info_and_computedmemberexpression_static_property_name_
branch
from
762ba87 to
433998f
Compare
graphite-app
bot
force-pushed
the
graphite-base/11882
branch
from
942808a to
66dbf9d
Compare
graphite-app
bot
force-pushed
the
06-24-perf_ast_remove_redundant_checks_from_memberexpression_static_property_info_and_computedmemberexpression_static_property_name_
branch
from
433998f to
debdbba
Compare
Contributor
Merge activity
|
…perty_info` and `ComputedMemberExpression::static_property_name` (#11882) Small optimization to `MemberExpression::static_property_info` and `ComputedMemberExpression::static_property_name`. If `lit.quasis.len() == 1`, `lit.expressions.is_empty()` is always true, so no need to check both.
graphite-app
bot
force-pushed
the
06-24-perf_ast_remove_redundant_checks_from_memberexpression_static_property_info_and_computedmemberexpression_static_property_name_
branch
from
debdbba to
5500d2d
Compare
overlookmotel
added a commit
that referenced
this pull request
Jun 24, 2025
graphite-app
bot
deleted the
06-24-perf_ast_remove_redundant_checks_from_memberexpression_static_property_info_and_computedmemberexpression_static_property_name_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to
MemberExpression::static_property_infoandComputedMemberExpression::static_property_name. Iflit.quasis.len() == 1,lit.expressions.is_empty()is always true, so no need to check both.