Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jun 25, 2025

Follow-up to some comments in #11766. This addresses an issue where we were not properly checking which side of assignment the prototype access occurred on.

Copy link
Member Author

camchenry commented Jun 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11888 will not alter performance

Comparing 06-24-fix_linter_remove_false_positives_for_no-extend-native_ (a358797) with main (6f67b52)

Summary

✅ 38 untouched benchmarks

@camchenry camchenry force-pushed the 06-24-fix_linter_remove_false_positives_for_no-extend-native_ branch 2 times, most recently from d07a762 to 4c516d3 Compare June 25, 2025 04:03
@camchenry camchenry force-pushed the 06-24-fix_linter_remove_false_positives_for_no-extend-native_ branch from 4c516d3 to 6ff0a59 Compare June 25, 2025 04:26
@camchenry camchenry marked this pull request as ready for review June 25, 2025 04:26
@camchenry camchenry requested a review from camc314 as a code owner June 25, 2025 04:26
@camc314 camc314 changed the base branch from 06-17-refactor_ast_add_astkind_for_staticmemberexpression_ to graphite-base/11888 June 25, 2025 11:13
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
Copy link
Contributor

camc314 commented Jun 25, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/11888 to main June 25, 2025 11:30
@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter labels Jun 25, 2025
Follow-up to some comments in #11766. This addresses an issue where we were not properly checking which side of assignment the prototype access occurred on.
@graphite-app graphite-app bot force-pushed the 06-24-fix_linter_remove_false_positives_for_no-extend-native_ branch from 6ff0a59 to a358797 Compare June 25, 2025 11:31
@graphite-app graphite-app bot merged commit a358797 into main Jun 25, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-24-fix_linter_remove_false_positives_for_no-extend-native_ branch June 25, 2025 11:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter Area - Linter A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants