feat(linter): load custom JS plugins #11980

camc314 · 2025-06-30T08:02:46Z

No description provided.

camc314 · 2025-06-30T08:03:01Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-06-30T08:06:12Z

CodSpeed Instrumentation Performance Report

Merging #11980 will not alter performance

_{Comparing c/06-30-feat_linter_load_custom_js_plugins (bde1ef1) with main (8814c53)}

Summary

✅ 34 untouched benchmarks

overlookmotel · 2025-07-08T17:47:02Z

napi/playground/Cargo.toml

 oxc_napi = { workspace = true }

-napi = { workspace = true }
+napi = { workspace = true, features = ["async"] }


Any way we can avoid this?

overlookmotel · 2025-07-08T17:47:41Z

Merge activity

Jul 8, 5:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 8, 5:47 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jul 8, 5:56 PM UTC: Merged by the Graphite merge queue.

overlookmotel · 2025-07-08T17:49:48Z

I've got some suggested changes, but I'll do them as follow-up PRs.

Follow-on after #11980. `tokio` dependency is only required if `oxlint2` feature is enabled.

…2` and `disable_oxlint2` features (#12141) Follow-on after #11980. Prevent this function being compiled in `oxc_linter` tests. It should be unreachable anyway.

Follow-on after #11980. Skip creating a `Resolver` unless there are JS plugins which need to be resolved. Creating a `Resolver` is not so expensive, but it's not super-cheap either.

Follow-on after #11980. Small optimization. Move work out of `load_external_plugin` to before the loop which calls `load_external_plugin`, so this work is done once rather than repeatedly for each plugin.

Follow-on after #11980. Pure refactor, and this is a matter of personal preference. Personally, I find `.into()` confusing as it's not clear "into what?". I find more explicit code like `.to_string()` clearer.

Follow-on after #11980. Pure refactor. Rename vars from `plugin_name` to `plugin_specifier`, because that better describes what they are. Later on, we'll add code which does deal with actual plugin names, at which point it'll become confusing.

## [1.7.0] - 2025-07-16 ### 🚀 Features - 5e428a4 linter/eslint-plugin-next: No-html-link-for-pages rule addition (#12194) (Gabriel Díaz Aguilera) - 9b14fbc ast: Add `ThisExpression` to `TSTypeName` (#12156) (Boshen) - c551b8f linter: Report diagnostics from custom plugins (#12219) (camc314) - d387729 linter: JS custom rules config (#12160) (camc314) - 152e59d napi/oxlint: Read source text into start of allocator (#12122) (overlookmotel) - bde1ef1 linter: Load custom JS plugins (#11980) (camc314) - d4ebd14 linter: Add `oxlint2`/`disable_oxlint2` feature flags (#12130) (camc314) - a4dae73 linter: Introduce `LintPlugins` to store builtin + custom plugins (#12117) (camc314) ### 🐛 Bug Fixes - 3f9a1f0 linter/no-unused-private-class-members: Fix false positive with nullish coalescing assignments (#12317) (camc314) - 47fad0e linter/no-empty-file: False positive with empty file with triple slash directive (#12293) (camc314) - 633ba30 linter: False positive with unknown plugins when unmatched eslint rule (#12285) (camc314) - 9720774 linter: Report implicit config parse errors (#12260) (Simon Buchan) - 1920c6b language_server: Respect the root `.oxlintrc.json` file for `ignorePatterns` (#12171) (Sysix) - 98708eb linter: Fix inconsistent behavior in `no-duplicate-imports` rule (#12192) (yefan) - 853d2bc linter, language_server: Correctly identify usage of `import` plugin (#12157) (overlookmotel) ### 🚜 Refactor - ee761de ast: Remove `AstKind` for `AssignmentTarget` (#12252) (Tyler Earls) - c68b607 ast: Rename `TemplateLiteral::quasi` to `TemplateLiteral::single_quasi` (#12266) (Dunqing) - 32c32af ast: Check whether there is a single `quasi` in `TemplateLiteral::quasi` (#12265) (Dunqing) - 8f6a1da linter/js-plugins: Use `u32` for IDs (#12243) (overlookmotel) - 36cd364 linter/js-plugins: Clean up code (#12242) (overlookmotel) - 8c02ebd linter/js-plugins: Rename `specifiers` to `paths` (#12241) (overlookmotel) - 3adaf98 linter: Simplify getting nodes count (#12239) (overlookmotel) - 6e54645 language_server: Store `LintService` instead of `Linter` (#12016) (Sysix) - 113cf8c linter: Move `LintServiceOptions.paths` to `LintService.with_paths` (#12015) (Sysix) - acfac68 oxlint: Adjust ignore patterns by counting bytes instead of chars (#12209) (Sysix) - 729b82b linter: Rename `plugin_name` to `plugin_specifier` (#12148) (overlookmotel) - 532b816 linter: Use `to_string` instead of `into` (#12147) (overlookmotel) - 89f2a69 linter: TODO comment (#12146) (overlookmotel) - f90d3e1 linter: Feature gate `load_external_plugin` by both `oxlint2` and `disable_oxlint2` features (#12141) (overlookmotel) - 12e4ec7 linter: Make `tokio` dependency optional (#12140) (overlookmotel) - 1d2eaca oxlint2: Introduce `force_test_reporter` feature for consistent graphical outputs (#12133) (camc314) - 8814c53 ast: Remove `AstKind` for `PropertyKey` (#12108) (camchenry) - 228cff5 semantic,linter: Assert that Program is always the first node (#12123) (Ulrich Stark) - e8e2a25 ast: Remove `AstKind` for `AssignmentTargetPattern` (#12105) (camchenry) - f7c675d linter: Rename `LintPlugins` to `BuiltinLintPlugins` (#12116) (camc314) - a9e5ec0 linter: Access plugins through config instead of storing directly (#12115) (camc314) - 9736a7f linter: Simplify `unicorn/require-post-message-target-origin` (#12110) (shulaoda) ### 📚 Documentation - 2e3db46 linter: Add missing backtick preventing website from building (#12113) (camc314) ### ⚡ Performance - d0f8b88 linter/js-plugins: Do not copy `Vec` (#12248) (overlookmotel) - 4284d19 linter/js-plugins: Use hashmap `Entry` API + remove temp `Vec` (#12247) (overlookmotel) - c7889c3 semantic,linter: Simplify implementation and uses of ancestors iterators (#12164) (Ulrich Stark) - f99959c linter: Move work out of loop (#12145) (overlookmotel) - 514d40c linter: Do not create `Resolver` unless required (#12142) (overlookmotel) - 7103527 linter/no-constructor-return: Optimize loop (#12138) (overlookmotel) ### 🧪 Testing - d1194e8 oxlint: Ignore test on windows (#12262) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Jun 30, 2025

camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 2 times, most recently from fe3ca9b to a372299 Compare June 30, 2025 08:12

github-actions bot added the A-editor Area - Editor and Language Server label Jun 30, 2025

camc314 changed the base branch from main to graphite-base/11980 June 30, 2025 08:41

camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from a372299 to ded5bc6 Compare June 30, 2025 08:41

camc314 changed the base branch from graphite-base/11980 to c/06-30-refactor_linter_remove_rulescache_ June 30, 2025 08:41

camc314 mentioned this pull request Jun 30, 2025

refactor(linter): remove RulesCache #11981

Merged

graphite-app bot changed the base branch from c/06-30-refactor_linter_remove_rulescache_ to graphite-base/11980 June 30, 2025 08:47

graphite-app bot force-pushed the graphite-base/11980 branch from 1f2301d to 3f91f24 Compare June 30, 2025 08:50

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from ded5bc6 to 3318c15 Compare June 30, 2025 08:50

graphite-app bot changed the base branch from graphite-base/11980 to main June 30, 2025 08:51

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 3318c15 to 6694fb7 Compare June 30, 2025 08:51

camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 4 times, most recently from bec71cb to dc201ac Compare July 3, 2025 09:01

camc314 changed the base branch from main to graphite-base/11980 July 3, 2025 11:05

camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from dc201ac to 26612f5 Compare July 3, 2025 11:05

camc314 changed the base branch from graphite-base/11980 to c/07-03-feat_linter_introduce_externallinter_struct July 3, 2025 11:05

This was referenced Jul 3, 2025

refactor(linter): mark napi::lint as async #12050

Merged

feat(linter): introduce ExternalLinter struct #12052

Merged

camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 4 times, most recently from 7c6e7c5 to 78dd57a Compare July 3, 2025 17:05

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 6eb79c2 to 774d956 Compare July 8, 2025 16:19

graphite-app bot changed the base branch from c/07-08-refactor_oxlint2_introduce_force_test_reporter_feature_for_consistent_graphical_outputs to graphite-base/11980 July 8, 2025 17:08

graphite-app bot force-pushed the graphite-base/11980 branch from 1141614 to 1d2eaca Compare July 8, 2025 17:17

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 774d956 to 724ac27 Compare July 8, 2025 17:17

graphite-app bot changed the base branch from graphite-base/11980 to main July 8, 2025 17:18

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 724ac27 to da5b461 Compare July 8, 2025 17:18

overlookmotel approved these changes Jul 8, 2025

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 8, 2025

feat(linter): load custom JS plugins (#11980)

bde1ef1

graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from da5b461 to bde1ef1 Compare July 8, 2025 17:48

This was referenced Jul 8, 2025

refactor(linter): make tokio dependency optional #12140

Merged

refactor(linter): feature gate load_external_plugin by both oxlint2 and disable_oxlint2 features #12141

Merged

graphite-app bot merged commit bde1ef1 into main Jul 8, 2025
25 checks passed

graphite-app bot deleted the c/06-30-feat_linter_load_custom_js_plugins branch July 8, 2025 17:56

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 8, 2025

graphite-app bot pushed a commit that referenced this pull request Jul 9, 2025

refactor(linter): make tokio dependency optional (#12140)

12e4ec7

Follow-on after #11980. `tokio` dependency is only required if `oxlint2` feature is enabled.

oxc-bot mentioned this pull request Jul 16, 2025

release(oxlint): v1.7.0 #12326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): load custom JS plugins #11980

feat(linter): load custom JS plugins #11980

camc314 commented Jun 30, 2025 •

edited

Loading

Uh oh!

camc314 commented Jun 30, 2025 •

edited by overlookmotel

Loading

Uh oh!

codspeed-hq bot commented Jun 30, 2025 •

edited

Loading

Uh oh!

overlookmotel Jul 8, 2025

Uh oh!

overlookmotel commented Jul 8, 2025 •

edited by graphite-app bot

Loading

Uh oh!

overlookmotel commented Jul 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat(linter): load custom JS plugins #11980

feat(linter): load custom JS plugins #11980

Conversation

camc314 commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Jun 30, 2025 • edited by overlookmotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #11980 will not alter performance

Summary

Uh oh!

overlookmotel Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

overlookmotel commented Jul 8, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

overlookmotel commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camc314 commented Jun 30, 2025 •

edited

Loading

camc314 commented Jun 30, 2025 •

edited by overlookmotel

Loading

codspeed-hq bot commented Jun 30, 2025 •

edited

Loading

overlookmotel commented Jul 8, 2025 •

edited by graphite-app bot

Loading

overlookmotel commented Jul 8, 2025 •

edited

Loading