Skip to content

refactor(semantic): rename AstNodeIdAncestorsIter and add comments #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

refactor(semantic): rename AstNodeIdAncestorsIter and add comments #12136

merged 1 commit into from
Jul 9, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 8, 2025 •
edited
Loading

Follow-on after #12123. Pure refactor.

  • Rename AstNodeIdParentIter to AstNodeIdAncestorsIter, as that better describes what it is.
  • Add a new method.
  • Add comments.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 8, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Jul 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 8, 2025
This was referenced Jul 8, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review July 8, 2025 16:41
@overlookmotel overlookmotel requested a review from Dunqing as a code owner July 8, 2025 16:41
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12136 will not alter performance

Comparing 07-08-refactor_semantic_rename_astnodeidancestorsiter_and_add_comments (c868ee3) with main (7103527)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 9, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 9, 2025 •
edited
Loading

Merge activity

@overlookmotel
refactor(semantic): rename AstNodeIdAncestorsIter and add comments (#…
c868ee3 
…12136)

Follow-on after #12123. Pure refactor.

* Rename `AstNodeIdParentIter` to `AstNodeIdAncestorsIter`, as that better describes what it is.
* Add a `new` method.
* Add comments.
@graphite-app graphite-app bot force-pushed the 07-08-refactor_semantic_rename_astnodeidancestorsiter_and_add_comments branch from 066f1ab to c868ee3 Compare July 9, 2025 02:58
@graphite-app graphite-app bot merged commit c868ee3 into main Jul 9, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 9, 2025
@graphite-app graphite-app bot deleted the 07-08-refactor_semantic_rename_astnodeidancestorsiter_and_add_comments branch July 9, 2025 03:06
@oxc-bot oxc-bot mentioned this pull request Jul 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camchenry