feat(linter): JS custom rules config #12160

camc314 · 2025-07-09T14:35:14Z

No description provided.

camc314 · 2025-07-09T14:35:32Z

feat(linter): report diagnostics from custom plugins #12219
feat(linter): JS custom rules config #12160 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-10T09:57:41Z

CodSpeed Instrumentation Performance Report

Merging #12160 will not alter performance

_{Comparing c/07-09-feat_linter_js_custom_rules_config (d387729) with main (3adaf98)}

Summary

✅ 34 untouched benchmarks

crates/oxc_linter/src/lib.rs

napi/oxlint2/src/index.js

overlookmotel

👍 I'll do some follow-up PRs for small things.

crates/oxc_linter/src/external_plugin_store.rs

overlookmotel · 2025-07-12T17:25:56Z

Merge activity

Jul 12, 5:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 12, 5:35 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jul 12, 5:44 PM UTC: Merged by the Graphite merge queue.

Follow-on after #12160. Pure refactor. Use vars called `paths` when they're the full path of plugins. `specifiers` is what we're calling the things which appear in plugins array in config, which can be either bare specifiers or relative paths (`my-plugin` or `../plugins/my-plugin.js`).

Follow-on after #12160. Pure refactor. Various small code clean-ups: * Remove unnecessary type annotations. * Defererence early. * Improve doc comments. * Assertion error messages. * Remove unnecessary derives.

Follow-on after #12160. Use `u32` for inner type of `ExternalPluginId` and `ExternalRuleId`. The only advantage of `NonMaxU32` is that `Option<NonMaxU32>` is 4 bytes. That's why we use it for `ScopeId` etc. But `ExternalPluginId` and `ExternalRuleId` aren't stored in `Option`s, so it's simpler to use plain `u32`.

Follow-on after #12160. Pure refactor. Rename vars, notably name vars containing file paths `path` not `name`.

Follow-on after #12160. Pure refactor. Make `loadPlugin` and `lint` class methods, instead of class properties. This feels more natural to me. But if we do want to go with arrow functions, we should remove the `.bind(this)` calls in `run`, as they're pointless.

Follow-on after #12160. Alter rule interface to match ESLint.

…12247) Follow-on after #12160. Small perf optimization. * Use `HashMap::entry` to avoid looking up the entry for a key twice, and removing an entry and then inserting it back again. * Remove the temp `Vec` `external_rules_to_replace`. I think only reason for this pattern with `rules_to_replace` is borrow-checker restriction, but that doesn't apply here.

Follow-on after #12160. Small perf optimization. Use `retain` to filter the `Vec` in place, instead of creating a new `Vec` and dropping the old one.

## [1.7.0] - 2025-07-16 ### 🚀 Features - 5e428a4 linter/eslint-plugin-next: No-html-link-for-pages rule addition (#12194) (Gabriel Díaz Aguilera) - 9b14fbc ast: Add `ThisExpression` to `TSTypeName` (#12156) (Boshen) - c551b8f linter: Report diagnostics from custom plugins (#12219) (camc314) - d387729 linter: JS custom rules config (#12160) (camc314) - 152e59d napi/oxlint: Read source text into start of allocator (#12122) (overlookmotel) - bde1ef1 linter: Load custom JS plugins (#11980) (camc314) - d4ebd14 linter: Add `oxlint2`/`disable_oxlint2` feature flags (#12130) (camc314) - a4dae73 linter: Introduce `LintPlugins` to store builtin + custom plugins (#12117) (camc314) ### 🐛 Bug Fixes - 3f9a1f0 linter/no-unused-private-class-members: Fix false positive with nullish coalescing assignments (#12317) (camc314) - 47fad0e linter/no-empty-file: False positive with empty file with triple slash directive (#12293) (camc314) - 633ba30 linter: False positive with unknown plugins when unmatched eslint rule (#12285) (camc314) - 9720774 linter: Report implicit config parse errors (#12260) (Simon Buchan) - 1920c6b language_server: Respect the root `.oxlintrc.json` file for `ignorePatterns` (#12171) (Sysix) - 98708eb linter: Fix inconsistent behavior in `no-duplicate-imports` rule (#12192) (yefan) - 853d2bc linter, language_server: Correctly identify usage of `import` plugin (#12157) (overlookmotel) ### 🚜 Refactor - ee761de ast: Remove `AstKind` for `AssignmentTarget` (#12252) (Tyler Earls) - c68b607 ast: Rename `TemplateLiteral::quasi` to `TemplateLiteral::single_quasi` (#12266) (Dunqing) - 32c32af ast: Check whether there is a single `quasi` in `TemplateLiteral::quasi` (#12265) (Dunqing) - 8f6a1da linter/js-plugins: Use `u32` for IDs (#12243) (overlookmotel) - 36cd364 linter/js-plugins: Clean up code (#12242) (overlookmotel) - 8c02ebd linter/js-plugins: Rename `specifiers` to `paths` (#12241) (overlookmotel) - 3adaf98 linter: Simplify getting nodes count (#12239) (overlookmotel) - 6e54645 language_server: Store `LintService` instead of `Linter` (#12016) (Sysix) - 113cf8c linter: Move `LintServiceOptions.paths` to `LintService.with_paths` (#12015) (Sysix) - acfac68 oxlint: Adjust ignore patterns by counting bytes instead of chars (#12209) (Sysix) - 729b82b linter: Rename `plugin_name` to `plugin_specifier` (#12148) (overlookmotel) - 532b816 linter: Use `to_string` instead of `into` (#12147) (overlookmotel) - 89f2a69 linter: TODO comment (#12146) (overlookmotel) - f90d3e1 linter: Feature gate `load_external_plugin` by both `oxlint2` and `disable_oxlint2` features (#12141) (overlookmotel) - 12e4ec7 linter: Make `tokio` dependency optional (#12140) (overlookmotel) - 1d2eaca oxlint2: Introduce `force_test_reporter` feature for consistent graphical outputs (#12133) (camc314) - 8814c53 ast: Remove `AstKind` for `PropertyKey` (#12108) (camchenry) - 228cff5 semantic,linter: Assert that Program is always the first node (#12123) (Ulrich Stark) - e8e2a25 ast: Remove `AstKind` for `AssignmentTargetPattern` (#12105) (camchenry) - f7c675d linter: Rename `LintPlugins` to `BuiltinLintPlugins` (#12116) (camc314) - a9e5ec0 linter: Access plugins through config instead of storing directly (#12115) (camc314) - 9736a7f linter: Simplify `unicorn/require-post-message-target-origin` (#12110) (shulaoda) ### 📚 Documentation - 2e3db46 linter: Add missing backtick preventing website from building (#12113) (camc314) ### ⚡ Performance - d0f8b88 linter/js-plugins: Do not copy `Vec` (#12248) (overlookmotel) - 4284d19 linter/js-plugins: Use hashmap `Entry` API + remove temp `Vec` (#12247) (overlookmotel) - c7889c3 semantic,linter: Simplify implementation and uses of ancestors iterators (#12164) (Ulrich Stark) - f99959c linter: Move work out of loop (#12145) (overlookmotel) - 514d40c linter: Do not create `Resolver` unless required (#12142) (overlookmotel) - 7103527 linter/no-constructor-return: Optimize loop (#12138) (overlookmotel) ### 🧪 Testing - d1194e8 oxlint: Ignore test on windows (#12262) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Jul 9, 2025

github-actions bot added the C-enhancement Category - New feature or request label Jul 9, 2025

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch from 66a705b to 72b648e Compare July 10, 2025 09:53

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch 2 times, most recently from 24572a2 to b7befc6 Compare July 10, 2025 11:39

camc314 commented Jul 10, 2025

View reviewed changes

crates/oxc_linter/src/lib.rs Show resolved Hide resolved

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch 2 times, most recently from 2c56050 to 25b4afd Compare July 10, 2025 15:01

github-actions bot added the A-editor Area - Editor and Language Server label Jul 10, 2025

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch 10 times, most recently from 543a049 to b34e439 Compare July 11, 2025 11:02

camc314 marked this pull request as ready for review July 11, 2025 11:04

camc314 requested a review from Sysix as a code owner July 11, 2025 11:04

graphite-app bot reviewed Jul 11, 2025

View reviewed changes

napi/oxlint2/src/index.js Show resolved Hide resolved

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch from b34e439 to 170c6fb Compare July 11, 2025 11:09

graphite-app bot reviewed Jul 11, 2025

View reviewed changes

napi/oxlint2/src/index.js Outdated Show resolved Hide resolved

camc314 force-pushed the c/07-09-feat_linter_js_custom_rules_config branch from 170c6fb to a9c601f Compare July 11, 2025 11:13

camc314 mentioned this pull request Jul 11, 2025

feat(linter): report diagnostics from custom plugins #12219

Merged

overlookmotel approved these changes Jul 12, 2025

View reviewed changes

crates/oxc_linter/src/external_plugin_store.rs Show resolved Hide resolved

overlookmotel force-pushed the c/07-09-feat_linter_js_custom_rules_config branch from a9c601f to 57ff78b Compare July 12, 2025 17:25

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 12, 2025

feat(linter): JS custom rules config (#12160)

d387729

graphite-app bot force-pushed the c/07-09-feat_linter_js_custom_rules_config branch from 57ff78b to d387729 Compare July 12, 2025 17:36

graphite-app bot merged commit d387729 into main Jul 12, 2025
26 checks passed

graphite-app bot deleted the c/07-09-feat_linter_js_custom_rules_config branch July 12, 2025 17:44

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 12, 2025

graphite-app bot pushed a commit that referenced this pull request Jul 12, 2025

refactor(napi/oxlint): rename vars (#12244)

d0af30c

Follow-on after #12160. Pure refactor. Rename vars, notably name vars containing file paths `path` not `name`.

graphite-app bot pushed a commit that referenced this pull request Jul 12, 2025

fix(napi/oxlint): rule interface match ESLint (#12246)

1c2d4b0

Follow-on after #12160. Alter rule interface to match ESLint.

graphite-app bot pushed a commit that referenced this pull request Jul 12, 2025

perf(linter/js-plugins): do not copy Vec (#12248)

d0f8b88

Follow-on after #12160. Small perf optimization. Use `retain` to filter the `Vec` in place, instead of creating a new `Vec` and dropping the old one.

oxc-bot mentioned this pull request Jul 16, 2025

release(oxlint): v1.7.0 #12326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): JS custom rules config #12160

feat(linter): JS custom rules config #12160

Uh oh!

camc314 commented Jul 9, 2025

Uh oh!

camc314 commented Jul 9, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel left a comment

Uh oh!

Uh oh!

overlookmotel commented Jul 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(linter): JS custom rules config #12160

feat(linter): JS custom rules config #12160

Uh oh!

Conversation

camc314 commented Jul 9, 2025

Uh oh!

camc314 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12160 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

overlookmotel commented Jul 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Jul 9, 2025 •

edited

Loading

codspeed-hq bot commented Jul 10, 2025 •

edited

Loading

overlookmotel commented Jul 12, 2025 •

edited by graphite-app bot

Loading