diff --git a/crates/oxc_linter/src/lib.rs b/crates/oxc_linter/src/lib.rs index a3886ed86e922..addcda26d0f37 100644 --- a/crates/oxc_linter/src/lib.rs +++ b/crates/oxc_linter/src/lib.rs @@ -133,7 +133,7 @@ impl Linter { let should_run_on_jest_node = ctx_host.plugins().has_test() && ctx_host.frameworks().is_test(); - if path.ends_with(".d.ts") { + if path.to_str().is_some_and(|str| str.ends_with(".d.ts")) { return ctx_host.take_diagnostics(); } diff --git a/crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs b/crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs index e2b12483b6425..27f941cdc79e6 100644 --- a/crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs +++ b/crates/oxc_linter/src/rules/jsdoc/check_tag_names.rs @@ -1094,7 +1094,7 @@ fn test() { ), ]; - let dts_pass = vec![ + let _dts_pass: Vec<(&'static str, Option, Option)> = vec![ ( " /** @default 0 */ @@ -1158,18 +1158,20 @@ fn test() { None, ), ]; - let dts_fail = vec![( - " + let _dts_fail: Vec<(&'static str, Option, Option)> = + vec![( + " /** @typoo {string} (fail: invalid name) */ let a; ", - None, - None, - )]; + None, + None, + )]; Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, pass, fail).test_and_snapshot(); + // TODO: re-enable here when we officially support linting `.d.ts` files // Currently only 1 snapshot can be saved under a rule name - Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, dts_pass, dts_fail) - .change_rule_path("test.d.ts") - .test(); + // Tester::new(CheckTagNames::NAME, CheckTagNames::PLUGIN, dts_pass, dts_fail) + // .change_rule_path("test.d.ts") + // .test(); }