fix(napi/oxlint): use process.exitCode
#12344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 17, 2025
Contributor
Merge activity
|
Set `process.exitCode` instead of calling `process.exit()` to exit with an error. `process.exit()` is not recommended because it kills the process immediately, and stdout may not have been fully flushed yet, so output may be lost. https://nodejs.org/api/process.html#processexitcode This was news to me!
graphite-app
bot
force-pushed
the
07-17-test_napi_oxlint_add_test_case_with_many_files
branch
from
2081992 to
2e26c03
Compare
graphite-app
bot
force-pushed
the
07-17-fix_napi_oxlint_use_process.exitcode_
branch
from
22bc769 to
98b17e9
Compare
Base automatically changed from
07-17-test_napi_oxlint_add_test_case_with_many_files
to
main
July 17, 2025 09:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
process.exitCodeinstead of callingprocess.exit()to exit with an error.process.exit()is not recommended because it kills the process immediately, and stdout may not have been fully flushed yet, so output may be lost.https://nodejs.org/api/process.html#processexitcode
This was news to me!