Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 21, 2025

Previously minification methods were run when functions are changed
during the previous iteration, this is not longer the case after
addition of removing unused vars and inline constant values.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 21, 2025
Copy link
Member Author

Boshen commented Jul 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen marked this pull request as draft July 21, 2025 14:26
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #12429 will not alter performance

Comparing 07-21-refactor_minifier_remove_change_detection_based_on_function_changes (6838948) with main (124d376)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen marked this pull request as ready for review July 21, 2025 14:44
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2025
Copy link
Member Author

Boshen commented Jul 21, 2025

Merge activity

…#12429)

Previously minification methods were run when functions are changed
during the previous iteration, this is not longer the case after
addition of removing unused vars and inline constant values.
@graphite-app graphite-app bot force-pushed the 07-21-refactor_minifier_remove_change_detection_based_on_function_changes branch from 531e934 to 6838948 Compare July 21, 2025 14:48
@graphite-app graphite-app bot merged commit 6838948 into main Jul 21, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-21-refactor_minifier_remove_change_detection_based_on_function_changes branch July 21, 2025 14:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants