Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 23, 2025

Previously, prev_constant_value stores a Option<ConstantValue>, but we only use ConstantValue::Number, so simplify it to store a Option<f64>

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 23, 2025
Copy link
Member Author

Dunqing commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12461 will not alter performance

Comparing 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier (93a5b76) with 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string (f32c816)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review July 23, 2025 03:32
@Dunqing Dunqing requested a review from overlookmotel as a code owner July 23, 2025 03:32
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app graphite-app bot force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch 2 times, most recently from 1ea35fa to 53ed334 Compare July 23, 2025 04:29
@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier branch from 6891d8f to fd85cf5 Compare July 23, 2025 04:29
… enum member without an initialzier (#12461)

Previously, `prev_constant_value` stores a `Option<ConstantValue>`, but we only use `ConstantValue::Number`, so simplify it to store a `Option<f64>`
@graphite-app graphite-app bot force-pushed the 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string branch from 53ed334 to f32c816 Compare July 23, 2025 09:27
@graphite-app graphite-app bot force-pushed the 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier branch from fd85cf5 to 93a5b76 Compare July 23, 2025 09:28
Base automatically changed from 07-23-perf_transformer_typescript_store_atom_rather_than_string_for_constantvalue_string to main July 23, 2025 09:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 23, 2025

Merge activity

@graphite-app graphite-app bot merged commit 93a5b76 into main Jul 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-23-refactor_transformer_typescript_simplify_evaulating_the_of_value_an_enum_member_without_an_initialzier branch July 23, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants