-
-
Notifications
You must be signed in to change notification settings - Fork 721
fix(linter/array-callback-return): false postive with throw stmt in callback #13264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter/array-callback-return): false postive with throw stmt in callback #13264
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes a false positive in the array-callback-return linter rule where callbacks containing throw statements were incorrectly flagged as missing return statements. The fix recognizes that throw statements provide explicit control flow termination equivalent to return statements.
- Added handling for throw statements as explicit return status in the return checker
- Added comprehensive test coverage for throw statement scenarios
- Added integration test case demonstrating the fix for array callback functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| return_checker.rs | Adds throw statement handling and unit tests for the return status checker |
| mod.rs | Adds integration test case for array callback with throw statement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13264 will not alter performanceComparing Summary
Footnotes |
Merge activity
|
8ee748c to
fd14b39
Compare

fixes #13256