Skip to content

Conversation

@camchenry
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings August 26, 2025 01:49
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools C-performance Category - Solution not expected to change functional behavior, only performance labels Aug 26, 2025
@camchenry camchenry marked this pull request as draft August 26, 2025 01:49
@camchenry camchenry changed the base branch from main to 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file August 26, 2025 01:51
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 26, 2025

CodSpeed Instrumentation Performance Report

Merging #13300 will improve performances by 15.67%

Comparing 08-25-perf_linter_extract_node_types_from_more_rules (16221c0) with 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file (34aaba9)

Summary

⚡ 4 improvements
✅ 30 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
linter[RadixUIAdoptionSection.jsx] 1.3 ms 1.1 ms +15.67%
linter[binder.ts] 83.3 ms 74 ms +12.64%
linter[cal.com.tsx] 734.8 ms 661.8 ms +11.03%
linter[react.development.js] 31.1 ms 27.9 ms +11.33%

@camchenry camchenry changed the base branch from 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file to graphite-base/13300 August 26, 2025 02:12
@camchenry camchenry force-pushed the graphite-base/13300 branch from e0279a2 to 5d898e8 Compare August 26, 2025 02:12
@camchenry camchenry force-pushed the 08-25-perf_linter_extract_node_types_from_more_rules branch 3 times, most recently from 9c9cf16 to 76e67c5 Compare August 26, 2025 02:26
@camchenry camchenry changed the base branch from graphite-base/13300 to 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file August 26, 2025 02:28
@camchenry camchenry force-pushed the 08-25-perf_linter_extract_node_types_from_more_rules branch from e87c397 to 3d98ce4 Compare August 26, 2025 02:47
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from e0279a2 to 2381b5b Compare August 26, 2025 02:47
@camchenry camchenry force-pushed the 08-25-perf_linter_extract_node_types_from_more_rules branch from d5fe024 to 3d98ce4 Compare August 26, 2025 02:49
@camchenry camchenry force-pushed the 08-25-perf_linter_filter_out_rules_which_have_no_relevant_node_types_in_file branch from 2381b5b to 22f771e Compare August 26, 2025 02:51
Copy link
Member Author

camchenry commented Aug 26, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@camchenry camchenry closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-linter Area - Linter A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants