fix(linter/custom-plugins): enforce exact matching for disable directives

crates/oxc_linter/src/lib.rs

@@ -330,6 +330,13 @@ impl Linter {
                     let (plugin_name, rule_name) =
                         self.config.resolve_plugin_rule_names(external_rule_id);
 
+                    if ctx_host
+                        .disable_directives()
+                        .contains(&format!("{plugin_name}/{rule_name}"), span)
+                    {
+                        continue;
+                    }
+
                     ctx_host.push_diagnostic(Message::new(
                         OxcDiagnostic::error(diagnostic.message)
                             .with_label(span)

napi/oxlint2/test/__snapshots__/e2e.test.ts.snap

@@ -460,6 +460,51 @@ Found 2 warnings and 0 errors.
 Finished in Xms on 1 file using X threads."
 `;
 
+exports[`oxlint2 CLI > should respect disable directives for custom plugin rules 1`] = `
+"
+  x test-plugin(no-var): Use let or const instead of var
+   ,-[index.js:1:1]
+ 1 | var shouldError = 1;
+   : ^^^^^^^^^^^^^^^^^^^^
+ 2 | 
+   \`----
+
+  x ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-debugger.html\\eslint(no-debugger)]8;;\\: \`debugger\` statement is not allowed
+    ,-[index.js:10:1]
+  9 | // should trigger an error
+ 10 | debugger;
+    : ^^^^^^^^^
+ 11 | 
+    \`----
+  help: Remove the debugger statement
+
+  x test-plugin(no-var): Use let or const instead of var
+    ,-[index.js:16:1]
+ 15 | /* oxlint-disable-next-line test-plugin */ // \`test-plugin\` should be \`test-plugin/no-var\`
+ 16 | var incorrectlyDisabled = 4;
+    : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ 17 | 
+    \`----
+
+  x test-plugin(no-var): Use let or const instead of var
+    ,-[index.js:19:1]
+ 18 | /* oxlint-disable-next-line no-var */ // \`no-var\` should be \`test-plugin/no-var\`
+ 19 | var anotherIncorrectlyDisabled = 4;
+    : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ 20 | 
+    \`----
+
+  x test-plugin(no-var): Use let or const instead of var
+    ,-[index.js:22:1]
+ 21 | // This var should trigger an error again
+ 22 | var shouldErrorAgain = 3;
+    : ^^^^^^^^^^^^^^^^^^^^^^^^^
+    \`----
+
+Found 0 warnings and 5 errors.
+Finished in Xms on 1 file using X threads."
+`;
+
 exports[`oxlint2 CLI > should work with multiple rules 1`] = `
 "
   x basic-custom-plugin(no-debugger): Unexpected Debugger Statement

napi/oxlint2/test/e2e.test.ts

@@ -54,42 +54,48 @@
   it('should report an error if a custom plugin cannot be loaded', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/missing_custom_plugin');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should report an error if a rule is not found within a custom plugin', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/custom_plugin_missing_rule');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should report an error if a a rule is not found within a custom plugin (via overrides)', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/custom_plugin_via_overrides_missing_rule');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should report the correct severity when using a custom plugin', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/basic_custom_plugin_warn_severity');
     expect(exitCode).toBe(0);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should work with multiple rules', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/basic_custom_plugin_multiple_rules');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should receive data via `context`', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/context_properties');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
 
   it('should have UTF-16 spans in AST', async () => {
     const { stdout, exitCode } = await runOxlint('test/fixtures/utf16_offsets');
     expect(exitCode).toBe(1);
     expect(normalizeOutput(stdout)).toMatchSnapshot();
   });
+
+  it('should respect disable directives for custom plugin rules', async () => {
+    const { stdout, exitCode } = await runOxlint('test/fixtures/custom_plugin_disable_directives');
+    expect(exitCode).toBe(1);
+    expect(normalizeOutput(stdout)).toMatchSnapshot();
+  });
 });

napi/oxlint2/test/fixtures/custom_plugin_disable_directives/.oxlintrc.json

@@ -0,0 +1,9 @@
+{
+  "plugins": ["./test_plugin"],
+  "categories": { "correctness": "off" },
+  "rules": {
+    "test-plugin/no-var": "error",
+    "no-debugger": "error"
+  },
+  "ignorePatterns": ["test_plugin/**"]
+}

napi/oxlint2/test/fixtures/custom_plugin_disable_directives/index.js

@@ -0,0 +1,22 @@
+var shouldError = 1;
+
+// oxlint-disable-next-line test-plugin/no-var
+var shouldBeDisabled = 2;
+
+// eslint-disable-next-line no-debugger
+debugger;
+
+// should trigger an error
+debugger;
+
+/* oxlint-disable-next-line test-plugin/no-var */
+var anotherDisabled = 4;
+
+/* oxlint-disable-next-line test-plugin */ // `test-plugin` should be `test-plugin/no-var`
+var incorrectlyDisabled = 4;
+
+/* oxlint-disable-next-line no-var */ // `no-var` should be `test-plugin/no-var`
+var anotherIncorrectlyDisabled = 4;
+
+// This var should trigger an error again
+var shouldErrorAgain = 3;

napi/oxlint2/test/fixtures/custom_plugin_disable_directives/test_plugin/index.js

@@ -0,0 +1,21 @@
+export default {
+  meta: {
+    name: "test-plugin",
+  },
+  rules: {
+    "no-var": {
+      create(context) {
+        return {
+          VariableDeclaration(node) {
+            if (node.kind === "var") {
+              context.report({
+                message: "Use let or const instead of var",
+                node: node,
+              });
+            }
+          },
+        };
+      },
+    },
+  },
+};