Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 7, 2025

Follow-on after #13137. Correct a comment, as per #13137 (comment).

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Sep 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 7, 2025 07:43
Copilot AI review requested due to automatic review settings September 7, 2025 07:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an incorrect comment in the AstTypesBitset implementation that incorrectly referred to "bytes" when it should refer to "usizes".

  • Corrects a comment to accurately describe the unit of measurement used in the bit set calculation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 7, 2025

CodSpeed Instrumentation Performance Report

Merging #13572 will not alter performance

Comparing 09-06-fix_semantic_correct_comment_on_asttypesbitset_ (d6b2e57) with main (f00adbe)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (d6b2e57) during the generation of this report, so f00adbe was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the 09-06-fix_semantic_correct_comment_on_asttypesbitset_ branch from a05c272 to 444b867 Compare September 7, 2025 08:17
@overlookmotel overlookmotel removed the request for review from Dunqing September 7, 2025 08:18
@overlookmotel
Copy link
Member Author

I think this is pretty uncontroversial, so merging without review.

Copy link
Member Author

overlookmotel commented Sep 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-06-fix_semantic_correct_comment_on_asttypesbitset_ branch from 444b867 to d6b2e57 Compare September 7, 2025 08:25
@graphite-app graphite-app bot merged commit d6b2e57 into main Sep 7, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 09-06-fix_semantic_correct_comment_on_asttypesbitset_ branch September 7, 2025 08:30
Copilot AI pushed a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants