Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 9, 2025

Pure refactor. Previously Allocators were reset in AllocatorGuard's Drop impl. Instead move the reset() call into AllocatorPool::add, which AllocatorGuard::drop calls.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 9, 2025
Copy link
Member Author

overlookmotel commented Sep 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 9, 2025

CodSpeed Instrumentation Performance Report

Merging #13620 will not alter performance

Comparing 09-09-refactor_allocator_pool_move_resetting_into_allocatorpool_add_ (0dde7f0) with main (f9bff64)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (0dde7f0) during the generation of this report, so f9bff64 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 10, 2025

Merge activity

…13620)

Pure refactor. Previously `Allocator`s were reset in `AllocatorGuard`'s `Drop` impl. Instead move the `reset()` call into `AllocatorPool::add`, which `AllocatorGuard::drop` calls.
@graphite-app graphite-app bot force-pushed the 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory branch from cbef849 to a0d7389 Compare September 10, 2025 04:03
@graphite-app graphite-app bot force-pushed the 09-09-refactor_allocator_pool_move_resetting_into_allocatorpool_add_ branch from aed935a to 0dde7f0 Compare September 10, 2025 04:03
Base automatically changed from 09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory to main September 10, 2025 04:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 10, 2025
@graphite-app graphite-app bot merged commit 0dde7f0 into main Sep 10, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 09-09-refactor_allocator_pool_move_resetting_into_allocatorpool_add_ branch September 10, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants