-
-
Notifications
You must be signed in to change notification settings - Fork 719
refactor(allocator/pool): move resetting into AllocatorPool::add
#13620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
09-09-refactor_allocator_pool_move_resetting_into_allocatorpool_add_
Sep 10, 2025
Merged
refactor(allocator/pool): move resetting into AllocatorPool::add
#13620
graphite-app
merged 1 commit into
main
from
09-09-refactor_allocator_pool_move_resetting_into_allocatorpool_add_
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Instrumentation Performance ReportMerging #13620 will not alter performanceComparing Summary
Footnotes |
This was referenced Sep 9, 2025
49ba3fd to
6196929
Compare
6196929 to
cbef849
Compare
02481be to
aed935a
Compare
Contributor
Merge activity
|
…13620) Pure refactor. Previously `Allocator`s were reset in `AllocatorGuard`'s `Drop` impl. Instead move the `reset()` call into `AllocatorPool::add`, which `AllocatorGuard::drop` calls.
cbef849 to
a0d7389
Compare
aed935a to
0dde7f0
Compare
Base automatically changed from
09-09-refactor_allocator_pool_move_allocatorpool_into_own_directory
to
main
September 10, 2025 04:08
camc314
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Pure refactor. Previously
Allocators were reset inAllocatorGuard'sDropimpl. Instead move thereset()call intoAllocatorPool::add, whichAllocatorGuard::dropcalls.