fix(codegen): avoid backticks for object property keys in destructuring assignments

[Copilot]

Fixes #13558

Problem

When minifying JavaScript code with destructuring assignments that contain string literal property keys (especially those with hyphens), the codegen was incorrectly using backticks instead of double quotes:

// Input
({"aria-label": ariaLabel} = input);

// Incorrect output (before fix)
({`aria-label`:ariaLabel}=input);

// Correct output (after fix)  
({"aria-label":ariaLabel}=input);

Root Cause

The issue was in the AssignmentTargetPropertyProperty implementation in crates/oxc_codegen/src/gen.rs. Unlike the regular PropertyKey implementation and other similar constructs (TSMethodSignature, TSPropertySignature, etc.), it was missing a specific case for PropertyKey::StringLiteral and was falling through to the default case that calls key.to_expression().print_expr(), which allows backticks by default.

Solution

Added explicit handling for PropertyKey::StringLiteral in the AssignmentTargetPropertyProperty::r#gen method to call p.print_string_literal(s, /* allow_backtick */ false), ensuring consistency with how property keys are handled elsewhere in the codebase.

The fix:

• Only affects destructuring assignments with string literal property keys
• Maintains existing behavior for all other cases (identifiers, computed properties, etc.)
• Follows the same pattern used in other PropertyKey implementations throughout the codebase

Testing

Added comprehensive test cases covering:

• Basic hyphenated property keys: {"aria-label": ariaLabel}
• Properties with newlines: {"key-with-newline\n": val}
• Mixed computed and literal properties: {["computed"]: a, "literal": b}
• Destructuring declarations: let {"test-key": testKey} = obj
• Object literals with string keys: ({ "test-key": key })
• Class properties with string keys: (class { "test-key" = key })

All existing tests continue to pass, confirming the fix doesn't break any existing functionality.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[sapphi-red]

@copilot add tests for the following cases

({ "test-key": key });
(class { "test-key" = key });

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13631 will not alter performance

_{Comparing copilot/fix-bb2a078b-eb5d-4baf-89f4-7e6d00125ae9 (bf50a02) with main (e66f93b)¹}

Summary

✅ 37 untouched benchmarks

Footnotes

1. No successful run was found on main (bf50a02) during the generation of this report, so e66f93b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

@copilot add tests for the following cases

({ "test-key": key });

...

Added tests for both requested cases:

• Object literal with string key: ({ "test-key": key })
• Class property with string key: (class { "test-key" = key })

Both test cases now verify that string literal property keys are properly handled with double quotes during minification. (c9bccc7)

[Copilot]

Pull Request Overview

This PR fixes a codegen issue where destructuring assignments with string literal property keys (especially hyphenated ones) were incorrectly using backticks instead of double quotes during minification.

• Added explicit handling for PropertyKey::StringLiteral in AssignmentTargetPropertyProperty
• Ensured string literals use double quotes by setting allow_backtick to false
• Added comprehensive test coverage for various destructuring scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_codegen/src/gen.rs	Added explicit PropertyKey::StringLiteral case to prevent backtick usage in destructuring assignments
crates/oxc_codegen/tests/integration/js.rs	Added test cases covering destructuring with string literal keys and mixed property types

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Boshen]

Merge activity

• Sep 10, 2:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 10, 2:58 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Sep 10, 3:04 AM UTC: Merged by the Graphite merge queue.