Skip to content

fix(linter): keep message when merging composite fixes #13827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

fix(linter): keep message when merging composite fixes #13827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/oxc_linter/src/fixer/fix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,9 +548,14 @@ impl<'a> CompositeFix<'a> {
let end = fixes[fixes.len() - 1].span.end;
let mut last_pos = start;
let mut output = String::new();
let mut merged_fix_message = None;

for fix in fixes {
let Fix { content, span, .. } = fix;
let Fix { content, span, message } = fix;
if let Some(message) = message {
merged_fix_message.get_or_insert(message);
}

// negative range or overlapping ranges is invalid
if span.start > span.end {
debug_assert!(false, "Negative range is invalid: {span:?}");
Expand Down Expand Up @@ -583,7 +588,12 @@ impl<'a> CompositeFix<'a> {

output.push_str(after);
output.shrink_to_fit();
Fix::new(output, Span::new(start, end))

let mut fix = Fix::new(output, Span::new(start, end));
if let Some(message) = merged_fix_message {
fix = fix.with_message(message);
}
fix
}
}

Expand Down
Loading