Skip to content

fix(formatter): keep computed name in enum #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2025
Merged

fix(formatter): keep computed name in enum #13848

merged 4 commits into from
Sep 18, 2025

Conversation

@nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented Sep 17, 2025

No description provided.

@nnnnoel nnnnoel requested a review from Dunqing as a code owner September 17, 2025 07:53
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Sep 17, 2025
@nnnnoel nnnnoel marked this pull request as draft September 17, 2025 07:55
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13848 will not alter performance

Comparing nnnnoel:fix/template-literal-in-enu (28c3582) with main (fa866b3)

Summary

✅ 37 untouched

@nnnnoel nnnnoel changed the title fix(formatter): computed template literal in enum fix(formatter): computed in enum Sep 17, 2025
@nnnnoel nnnnoel marked this pull request as ready for review September 17, 2025 08:00
@nnnnoel nnnnoel changed the title fix(formatter): computed in enum fix(formatter): keep computed name in enum Sep 17, 2025
@nnnnoel nnnnoel force-pushed the fix/template-literal-in-enu branch from a960d44 to d9c3dd6 Compare September 17, 2025 08:08
@Dunqing
Copy link
Member

Dunqing commented Sep 17, 2025

Please rebase and fix the conflicts

@nnnnoel nnnnoel force-pushed the fix/template-literal-in-enu branch from d9c3dd6 to 28c3582 Compare September 17, 2025 16:01
Dunqing
Dunqing approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dunqing Dunqing merged commit 57108c0 into oxc-project:main Sep 18, 2025
27 checks passed
This was referenced Sep 19, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nnnnoel @Dunqing