Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 18, 2025

browser.js is not used in napi/parser - wasm.mjs plays this role. browser.js file appears to be a left-over from a past version, before we had the wrap function.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 18, 2025
Copy link
Member Author

overlookmotel commented Sep 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025
Copy link
Contributor

camc314 commented Sep 19, 2025

Merge activity

  • Sep 19, 8:44 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 19, 8:44 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Sep 19, 8:44 AM UTC: The Graphite merge queue removed this pull request due to removal of a downstack PR #13899.
  • Sep 19, 8:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 19, 8:46 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Sep 19, 8:46 AM UTC: camc314 removed this pull request from the Graphite merge queue.
  • Sep 19, 8:46 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue

@camc314 camc314 removed the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025
@graphite-app graphite-app bot changed the base branch from 09-18-refactor_napi_parser_move_scripts_to_scripts_directory to graphite-base/13901 September 19, 2025 08:47
@graphite-app graphite-app bot force-pushed the graphite-base/13901 branch from 0f66b04 to 329b7e7 Compare September 19, 2025 08:52
@graphite-app graphite-app bot force-pushed the 09-18-refactor_napi_parser_remove_outdated_file branch from 8c702d3 to 5d886eb Compare September 19, 2025 08:52
@graphite-app graphite-app bot changed the base branch from graphite-base/13901 to main September 19, 2025 08:53
@graphite-app graphite-app bot force-pushed the 09-18-refactor_napi_parser_remove_outdated_file branch from 5d886eb to 861dfd3 Compare September 19, 2025 08:53
@overlookmotel
Copy link
Member Author

Actually, this change is wrong. The browser.js file is auto-generated by NAPI-RS, so can't be deleted. #13918

@overlookmotel overlookmotel deleted the 09-18-refactor_napi_parser_remove_outdated_file branch September 23, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants