Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 19, 2025

Follow up on #13766 (comment). declare classes have already been removed in TypeScript's enter_statements, so no declare classes will enter the class-properties plugin. Add a few debug_assertions to ensure this won't break in the future.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Sep 19, 2025
Copy link
Member Author

Dunqing commented Sep 19, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Instrumentation Performance Report

Merging #13907 will not alter performance

Comparing 09-19-feat_transformer_class-properties_add_debug_assertions_for_declare_class (c4f2d8c) with 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0 (c5c1672)

Summary

✅ 37 untouched

@Dunqing Dunqing changed the base branch from main to graphite-base/13907 September 19, 2025 02:11
@Dunqing Dunqing force-pushed the 09-19-feat_transformer_class-properties_add_debug_assertions_for_declare_class branch from 5ce8c9b to 55ef11d Compare September 19, 2025 02:11
@Dunqing Dunqing force-pushed the graphite-base/13907 branch from f067159 to 04666f6 Compare September 19, 2025 02:11
@Dunqing Dunqing changed the base branch from graphite-base/13907 to 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_ September 19, 2025 02:11
@Dunqing Dunqing force-pushed the 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_ branch from 04666f6 to 0bdf3bd Compare September 19, 2025 02:12
@Dunqing Dunqing force-pushed the 09-19-feat_transformer_class-properties_add_debug_assertions_for_declare_class branch from 55ef11d to 692b38e Compare September 19, 2025 02:12
@Dunqing Dunqing force-pushed the 09-19-feat_transformer_class-properties_add_debug_assertions_for_declare_class branch from 692b38e to c4f2d8c Compare September 19, 2025 02:17
@Dunqing Dunqing force-pushed the 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_ branch from 0bdf3bd to c5c1672 Compare September 19, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants